Skip to content

[WIP] Optimize json marshaller #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alextwoods wants to merge 2 commits into
base: master
Choose a base branch
from

Refactor code to reduce duplication from switch statement

3a48144
Select commit
Loading
Failed to load commit list.
Draft

[WIP] Optimize json marshaller #6857

Refactor code to reduce duplication from switch statement
3a48144
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 14, 2026 in 15m 32s

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 365 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "double". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3J&open=AZ2IqGFGroWKLK634S3J&pullRequest=6857

Check warning on line 144 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/functionaltests/AutoGeneratedTimestampRecordTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGmroWKLK634S3T&open=AZ2IqGGmroWKLK634S3T&pullRequest=6857

Check warning on line 62 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/internal/EnhancedClientUtilsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGNroWKLK634S3P&open=AZ2IqGGNroWKLK634S3P&pullRequest=6857

Check warning on line 373 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "boolean". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3K&open=AZ2IqGFGroWKLK634S3K&pullRequest=6857

Check warning on line 473 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/functionaltests/UpdateBehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThat(actual).hasToString(expectedString) instead. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGHGroWKLK634S3Z&open=AZ2IqGHGroWKLK634S3Z&pullRequest=6857

Check failure on line 202 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3D&open=AZ2IqGFGroWKLK634S3D&pullRequest=6857

Check warning on line 61 in core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkFieldCacheMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEVroWKLK634S25&open=AZ2IqGEVroWKLK634S25&pullRequest=6857

Check warning on line 50 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/functionaltests/AutoGeneratedTimestampRecordTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.enhanced.dynamodb.internal.extensions.DefaultDynamoDbExtensionContext'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGmroWKLK634S3W&open=AZ2IqGGmroWKLK634S3W&pullRequest=6857

Check warning on line 77 in core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkFieldCacheMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEVroWKLK634S26&open=AZ2IqGEVroWKLK634S26&pullRequest=6857

Check warning on line 68 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/NonResponsiveServerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "socket" local variable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGH3roWKLK634S3a&open=AZ2IqGH3roWKLK634S3a&pullRequest=6857

Check warning on line 496 in core/protocols/aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/internal/marshall/PayloadMarshallingEquivalenceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEqroWKLK634S3B&open=AZ2IqGEqroWKLK634S3B&pullRequest=6857

Check warning on line 74 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/functionaltests/AutoGeneratedTimestampRecordTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "PRIMARY_CONTEXT" private field. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGmroWKLK634S3X&open=AZ2IqGGmroWKLK634S3X&pullRequest=6857

Check warning on line 349 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "long". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3F&open=AZ2IqGFGroWKLK634S3F&pullRequest=6857

Check warning on line 27 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/NonResponsiveServerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.concurrent.CompletionException'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGH3roWKLK634S3e&open=AZ2IqGH3roWKLK634S3e&pullRequest=6857

Check warning on line 357 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "byte". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3H&open=AZ2IqGFGroWKLK634S3H&pullRequest=6857

Check warning on line 60 in core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkField.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a thread-safe type; adding "volatile" is not enough to make this field thread-safe. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGAGroWKLK634S23&open=AZ2IqGAGroWKLK634S23&pullRequest=6857

Check warning on line 353 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "short". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3G&open=AZ2IqGFGroWKLK634S3G&pullRequest=6857

Check warning on line 96 in core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkFieldCacheMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEVroWKLK634S27&open=AZ2IqGEVroWKLK634S27&pullRequest=6857

Check warning on line 606 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/functionaltests/AutoGeneratedTimestampRecordTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable to not match a restricted identifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGmroWKLK634S3V&open=AZ2IqGGmroWKLK634S3V&pullRequest=6857

Check warning on line 184 in core/protocols/aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/internal/marshall/PayloadMarshallingEquivalenceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEqroWKLK634S2-&open=AZ2IqGEqroWKLK634S2-&pullRequest=6857

Check warning on line 70 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/NonResponsiveServerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGH3roWKLK634S3b&open=AZ2IqGH3roWKLK634S3b&pullRequest=6857

Check warning on line 30 in services-custom/dynamodb-enhanced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/internal/EnhancedClientUtilsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGGNroWKLK634S3Q&open=AZ2IqGGNroWKLK634S3Q&pullRequest=6857

Check warning on line 49 in core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkFieldCacheMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEVroWKLK634S24&open=AZ2IqGEVroWKLK634S24&pullRequest=6857

Check warning on line 31 in core/sdk-core/src/test/java/software/amazon/awssdk/core/SdkFieldCacheMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGEVroWKLK634S28&open=AZ2IqGEVroWKLK634S28&pullRequest=6857

Check warning on line 345 in core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "int". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ2IqGFGroWKLK634S3E&open=AZ2IqGFGroWKLK634S3E&pullRequest=6857
View more details on SonarQubeCloud