Fix AutoGeneratedTimestampRecordExtension failing on @DynamoDbConvertedBy list attributes#6854
Open
alextwoods wants to merge 2 commits intomasterfrom
Open
Fix AutoGeneratedTimestampRecordExtension failing on @DynamoDbConvertedBy list attributes#6854alextwoods wants to merge 2 commits intomasterfrom
alextwoods wants to merge 2 commits intomasterfrom
Conversation
…edBy list attributes (#6852)
Contributor
Author
|
Fred1155
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Motivation and Context
Fixes #6852
PR #6546 added nested record support to
AutoGeneratedTimestampRecordExtension, which recursively introspects all attributes to find@DynamoDbAutoGeneratedTimestampAttributefields in nested types. This introspection does not respect@DynamoDbConvertedByon list attributes — it attempts to resolve aTableSchemafor the list element type even when a custom converter already handles serialization.If the list element class is not annotated with
@DynamoDbBeanor@DynamoDbImmutable,TableSchema.fromClass()throwsIllegalArgumentException. This is a regression for any@DynamoDbBeanthat has both a@DynamoDbAutoGeneratedTimestampAttributefield and aList<T>field with@DynamoDbConvertedBywhereTis not a DynamoDB-annotated class.Modifications
In
NestedRecordUtils.getTableSchemaForListElement(), before callingTableSchema.fromClass()on the list element type, check whether the class has@DynamoDbBeanor@DynamoDbImmutableannotations. If neither is present, returnnullinstead of throwing. The callers inAutoGeneratedTimestampRecordExtensionalready handlenullby skipping introspection for that attribute.Testing
NestedRecordUtilsTestverifyinggetTableSchemaForListElementreturnsnullfor non-annotated element types and thatgetListElementSchemaCachedcaches the null result.AutoGeneratedTimestampExtensionTestverifyingbeforeWritesucceeds and correctly sets the auto-generated timestamp while leaving@DynamoDbConvertedBylist and map attributes unchanged.Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License