Repository navigation
Remove deprecated S3 encryption clients, replaced credentials providers and unused code #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/1.12
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "Remove ProcessCredentialsProvider and the original ProfileConfigFileAWSCredentialsProvider, which the default chain stopped using once the CRT-backed ProfileCredentialsProvider took over their work. ProfileConfigFileAWSCredentialsProvider still compiles as a deprecated alias of ProfileCredentialsProvider; use ProfileCredentialsProvider for credential_process too. ProfileCredentialsProvider's default constructor picks the profile from AWS_PROFILE, then default; unlike the old provider, it does not read AWS_DEFAULT_PROFILE, and an empty AWS_PROFILE is not treated as default, so set it to a profile name or unset it. Unlike the old provider, ProfileCredentialsProvider reads the config and credentials files once when it is created, so keys rotated in the files are picked up only by a new provider. It also follows the shared config file format strictly: a line that starts with whitespace continues the previous property, so a profile line indented by mistake can stop the file from loading. Requests using credential_process now report the profile credentials feature in the user agent instead of the process credentials feature. AWSCredentialsProvider.h no longer includes GeneralHTTPCredentialsProvider.h; include it directly to use GeneralHTTPCredentialsProvider or TaskRoleCredentialsProvider." | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-s3-encryption", | ||
| "contributor": "averyk22", | ||
| "description": "Remove the deprecated S3EncryptionClient and S3EncryptionClientV2, along with CryptoConfigurationV2. Use S3EncryptionClientV3 with CryptoConfigurationV3; call AllowLegacy() on the configuration to keep reading objects the older clients wrote. S3EncryptionClientBase's constructors are now protected, so the base client can no longer be built directly with legacy encryption settings." | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "Remove code the SDK never used: Aws::Utils::GetTheLights, the aws/core/utils/memory/stl/AWSMultiMap.h header and aws/core/external/CommonCryptorSPI.h. Aws::MultiMap is still available from aws/core/utils/memory/stl/AWSMap.h." | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "bugfix", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "CRT-backed credentials providers, including ProfileCredentialsProvider in the default chain, now return the account ID from aws_account_id in the profile and AccountId in credential_process output. Without it, DynamoDB fell back from account-based endpoints to the regional endpoint, and accountIdEndpointMode=required failed." | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,17 +12,20 @@ namespace Auth { | |
| /** | ||
| * CRT-based credentials provider that sources credentials from config files with full SEP compliance. | ||
| * Supports assume role, credential_source, role chaining, and all SEP scenarios. | ||
| * | ||
| * The config and credentials files are read once, when the provider is created. Credentials that expire, such as | ||
| * from assume role or credential_process, are refreshed from those settings, but later changes to the files, such | ||
| * as rotated keys, are only picked up by a new provider. | ||
| */ | ||
| class AWS_CORE_API ProfileCredentialsProvider : public AWSCredentialsProvider { | ||
| public: | ||
| /** | ||
| * Initializes with refreshRateMs as the frequency at which the file is reparsed in milliseconds. Defaults to 5 minutes. | ||
| * Initializes with the profile from AWS_PROFILE, then "default". AWS_DEFAULT_PROFILE is not read. | ||
| */ | ||
| ProfileCredentialsProvider(long refreshRateMs = REFRESH_THRESHOLD); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Since #3721 (Feb 27, 2026, first released in 1.11.760), Before #3721, the provider stored This PR keeps the |
||
|
|
||
| /** | ||
| * Initializes with a profile override and | ||
| * refreshRateMs as the frequency at which the file is reparsed in milliseconds. Defaults to 5 minutes. | ||
| * Initializes with a profile override. | ||
| */ | ||
| ProfileCredentialsProvider(const char* profile, long refreshRateMs = REFRESH_THRESHOLD); | ||
|
|
||
|
|
@@ -54,5 +57,7 @@ class AWS_CORE_API ProfileCredentialsProvider : public AWSCredentialsProvider { | |
| class ProfileCredentialsProviderImp; | ||
| std::shared_ptr<ProfileCredentialsProviderImp> m_impl; | ||
| }; | ||
|
|
||
| using ProfileConfigFileAWSCredentialsProvider [[deprecated("Use ProfileCredentialsProvider")]] = ProfileCredentialsProvider; | ||
| } // namespace Auth | ||
| } // namespace Aws | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refresh: documented, not changed:
refreshRateMsis ignored andReload()is empty. The CRT reads the files once, and static keys never expire, so rotated keys need a new provider. Expiring credentials still refresh. Re-reading the files would be a behavior change, so this PR only documents it. Also note:DEFAULT_REFRESH_RATE_MSin the.cppis really the CRT fetch timeout, not a refresh rate.