Place generated files in CMAKE_BINARY_DIR.#3747
Place generated files in CMAKE_BINARY_DIR.#3747teo-tsirpanis wants to merge 1 commit intoaws:mainfrom
CMAKE_BINARY_DIR.#3747Conversation
|
@teo-tsirpanis After taking another look at the original issue, I wanted to follow up on when you said
Do we have an example where the current behavior causes a failure? Since the change also touches include paths and install behavior, it would be helpful to understand whether this is addressing a concrete issue. |
|
The patch is being used in vcpkg since microsoft/vcpkg#46105 for more than half a year without problems. Vcpkg builds ports in both debug and release mode, and to save time it configures them by default in parallel. Configuring from the same source tree in parallel doesn't work if a port writes to it, which according to my understanding is an anti-pattern either way. |
Issue #, if available:
Description of changes:
Note
This is a reopening of #3459, which was closed for reasons unknown to me.
This PR updates the CMake project to place generated files in the binary directory, instead of the source directory. This follows best practices, and unblocks the vcpkg port to support configuring
aws-sdk-cppin parallel.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.