Skip to content

Fix enable virtual operations#3719

Merged
sbiscigl merged 1 commit intomainfrom
fix-enable-virtual-operations
Feb 12, 2026
Merged

Fix enable virtual operations#3719
sbiscigl merged 1 commit intomainfrom
fix-enable-virtual-operations

Conversation

@sbiscigl
Copy link
Contributor

Issue #, if available:

#3715

Description of changes:

  • creates a easier interface to disable methods on clients via the python code gen for users that want to link statically and use link optimizations to lower the binary size
python3.9 tools/scripts/run_code_generation.py --client_list s3 --disable-virtual-operations --debug
  • adds virtual correctly to all functions in a service client, and the "vitrualness" of these functions will adhere to the enable-virutal-functions codegen parameter.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the fix-enable-virtual-operations branch from 2146071 to 311727e Compare February 11, 2026 18:46
@sbiscigl sbiscigl marked this pull request as ready for review February 11, 2026 18:46
@sbiscigl sbiscigl force-pushed the fix-enable-virtual-operations branch 3 times, most recently from d07ed0d to 955707b Compare February 11, 2026 22:41
@sbiscigl sbiscigl force-pushed the fix-enable-virtual-operations branch from 955707b to 975e0cd Compare February 12, 2026 15:00
@sbiscigl sbiscigl merged commit 08f8a69 into main Feb 12, 2026
5 checks passed
@sbiscigl sbiscigl deleted the fix-enable-virtual-operations branch February 12, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants