Smithy generator for paginator #3690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaluja
reviewed
Jan 15, 2026
| public CppWriter writeNamespaceClose(String namespace) { | ||
| write("} // namespace $L", namespace); | ||
| return this; | ||
| } |
Contributor
There was a problem hiding this comment.
Being a bit nitpicky but Instead of manually opening and closing namespace blocks, why don't we do something like this:
public CppWriter writeNamespaceOpen(String namespace) {
writer.openBlock("namespace $L\n{", namespace);
return this;
}
and the same for writeNamespaceClose, but with writer.closeBlock. Its functionally the exact same (block functions indent/dedent which doesn't matter since we clang format anyway) , but we should try to use these functions when opening/closing blocks
kai-ion
force-pushed
the
paginatorModel
branch
from
9bd93d6 to
3d3e5a6
Compare
kai-ion
force-pushed
the
paginatorModel
branch
from
3d3e5a6 to
1eb974f
Compare
…ervice name and add sdk suffix
kai-ion
force-pushed
the
paginatorModel
branch
2 times, most recently
from
445995a to
927dee5
Compare
… the logic to be exactly like the legacy c2j formater
…ename reshape priority
…nged shapeutil logic to correctly use the legacy get/set collision rule
Fix pagination traits generator for nested tokens andle explicit nested tokens like "EngineDefaults.Marker" correctly
abbreviation and servicename mismatch
Backward compatibility map for operations that must use "SdkResult" suffix.
S3's ListParts operation has NextPartNumberMarker as integer in C2J but string in Smithy.
kai-ion
force-pushed
the
paginatorModel
branch
from
4d86e15 to
0fd0691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Smithy-based code generator for paginators
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.