fix(build): share dependencies folder for functions with same manifest #8638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/build
This fixes the PyInstaller build failure where zlib download might fail due to HTTP redirects or server errors not being handled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
sam build --cached, Lambda functions that share the same manifest file (e.g.,package.json) get duplicate dependency folders created in.aws-sam/deps/. Each build definition uses a UUID to generate the dependencies directory name, regardless of whether the manifest is identical. This wastes disk space significantly in projects with many functions sharing the same dependencies.Changes
• Modified the naming strategy from UUID-based to a deterministic hash-based approach
• Dependencies folder name is now generated from
manifest_hash + runtime + architecture• Functions with the same manifest, runtime, and architecture share a single dependencies folder
• Existing cached dependencies folders (UUID-based) are cleaned up on the next build
• Backward compatible: if
manifest_hashis empty, falls back to UUID-based namingTesting
• Unit tests added and passing
•
make prpassesFixes #6732
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.