Conversation
enumura1
marked this pull request as ready for review
August 15, 2026 08:40
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
|
This PR was closed because it has become stale with no activity. |
LikithaVemulapalli
approved these changes
Sep 29, 2026
LikithaVemulapalli
left a comment
LikithaVemulapalli
left a comment
Contributor
There was a problem hiding this comment.
@enumura1 thanks for handling the inconsistency between the events with this PR, LGTM :)
Contributor
|
@enumura1 could you check the failed tests, we can only merge changes once the tests pass, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1284
Description of changes:
Return errors from Queue Processor pre-drain tasks when adding a taint fails.
Previously, taint errors were logged but treated as successful, allowing
node draining and SQS message deletion to continue.
Add tests for taint failures in ASG lifecycle, Rebalance Recommendation,
and Scheduled change events.
How you tested your changes:
pkg/monitor/sqseventandpkg/interruptionevent/draincordonvisibility timeout
Environment (Linux / Windows): Amazon Linux 2023 / Linux amd64
Kubernetes Version: EKS 1.34