chore(CFN): check in CFN#1375
Open
josecorella wants to merge 6 commits intomasterfrom
Open
Conversation
lucasmcdonald3
previously approved these changes
Mar 12, 2024
lucasmcdonald3
previously approved these changes
Mar 13, 2024
lucasmcdonald3
previously approved these changes
Mar 13, 2024
texastony
reviewed
May 19, 2024
Comment on lines
+1
to
+6
| Outputs: | ||
| StackArn: | ||
| Description: >- | ||
| Do not remove this output! Pipelines needs this to do its association. (And | ||
| LPT. Removing it will break things) | ||
| Value: !Ref 'AWS::StackId' |
Contributor
There was a problem hiding this comment.
Suggestion: If we maintain the CFN here, we cannot use BONES pipelines to maintain the Stack.
Suggested change
| Outputs: | |
| StackArn: | |
| Description: >- | |
| Do not remove this output! Pipelines needs this to do its association. (And | |
| LPT. Removing it will break things) | |
| Value: !Ref 'AWS::StackId' |
Comment on lines
+8
to
+22
| DeploymentBucketImportName: | ||
| Default: 'BONESBootstrap-PDX-beta-DeploymentBucket' | ||
| Description: >- | ||
| This parameter is meant to be passed by LPT (and piplines). It holds the | ||
| name of import that points to the bucket that holds your artifacts. You | ||
| should use this as the import (Fn::ImportValue: {Ref: DeploymentBucket}) | ||
| for getting any BATS related artifacts. | ||
| Type: String | ||
| Stage: | ||
| Default: 'beta' | ||
| Type: String | ||
| PipelinesControlledRegionBucket: | ||
| Type: String | ||
| Description: The regionalized bucket to read the artifact from. | ||
| Default: 'placeholder' |
Contributor
There was a problem hiding this comment.
Suggestion: If we maintain the CFN here, we cannot use BONES pipelines to maintain the Stack.
Suggested change
| DeploymentBucketImportName: | |
| Default: 'BONESBootstrap-PDX-beta-DeploymentBucket' | |
| Description: >- | |
| This parameter is meant to be passed by LPT (and piplines). It holds the | |
| name of import that points to the bucket that holds your artifacts. You | |
| should use this as the import (Fn::ImportValue: {Ref: DeploymentBucket}) | |
| for getting any BATS related artifacts. | |
| Type: String | |
| Stage: | |
| Default: 'beta' | |
| Type: String | |
| PipelinesControlledRegionBucket: | |
| Type: String | |
| Description: The regionalized bucket to read the artifact from. | |
| Default: 'placeholder' |
Comment on lines
+68
to
+70
| ExampleWaitHandle: | ||
| Properties: {} | ||
| Type: 'AWS::CloudFormation::WaitConditionHandle' |
Contributor
There was a problem hiding this comment.
Suggestion: Remove Example code from yee old BONES template
Suggested change
| ExampleWaitHandle: | |
| Properties: {} | |
| Type: 'AWS::CloudFormation::WaitConditionHandle' |
| Location: 'https://github.com/aws/aws-encryption-sdk-javascript' | ||
| ReportBuildStatus: 'true' | ||
| Type: GITHUB | ||
| Type: 'AWS::CodeBuild::Project' |
Contributor
There was a problem hiding this comment.
Suggestion/Nit: I find it easier to read CFN if I know the Type first.
Suggested change
| Type: 'AWS::CodeBuild::Project' |
| Resource: | ||
| - !Sub 'arn:aws:codebuild:${AWS::Region}:${AWS::AccountId}:project/JavaScriptESDK' | ||
| PolicyName: !Sub '${AWS::StackName}CloudWatchLogsPolicy' | ||
| Type: 'AWS::IAM::Role' |
Contributor
There was a problem hiding this comment.
Suggestion/Nit: I find it easier to read CFN if I know the Type first.
Suggested change
| Type: 'AWS::IAM::Role' |
Comment on lines
+31
to
+32
| CodeBuildRole: | ||
| Properties: |
Contributor
There was a problem hiding this comment.
Suggestion/Nit: I find it easier to read CFN if I know the Type first.
Suggested change
| CodeBuildRole: | |
| Properties: | |
| CodeBuildRole: | |
| Type: 'AWS::IAM::Role' | |
| Properties: |
Comment on lines
+71
to
+72
| JavaScriptESDK: | ||
| Properties: |
Contributor
There was a problem hiding this comment.
Suggestion/Nit: I find it easier to read CFN if I know the Type first.
Suggested change
| JavaScriptESDK: | |
| Properties: | |
| JavaScriptESDK: | |
| Type: 'AWS::CodeBuild::Project' | |
| Properties: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: