fix(testing): handle workflow failure states correctly - #682
Open
hln33 wants to merge 6 commits into
Open
Conversation
hln33
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 22:56 — with
GitHub Actions
Inactive
hln33
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 22:56 — with
GitHub Actions
Inactive
hln33
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 22:56 — with
GitHub Actions
Inactive
hln33
marked this pull request as draft
August 25, 2026 22:56
hln33
force-pushed
the
fix/656-emulator-null-invocation-error-causes-successful-execution
branch
from
August 25, 2026 22:59
f4129a2 to
b6a604a
Compare
hln33
force-pushed
the
fix/656-emulator-null-invocation-error-causes-successful-execution
branch
from
August 25, 2026 23:20
b6a604a to
861756a
Compare
hln33
force-pushed
the
fix/656-emulator-null-invocation-error-causes-successful-execution
branch
from
August 25, 2026 23:22
861756a to
09acaf6
Compare
hln33
had a problem deploying
to
ai-pr-review-runtime
August 25, 2026 23:35 — with
GitHub Actions
Failure
hln33
temporarily deployed
to
ai-pr-review-runtime
August 25, 2026 23:35 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
hln33
marked this pull request as ready for review
August 26, 2026 00:24
hln33
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 00:24 — with
GitHub Actions
Inactive
hln33
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 00:24 — with
GitHub Actions
Inactive
hln33
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 00:24 — with
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
bchampp
previously approved these changes
Aug 26, 2026
yaythomas
requested changes
Aug 26, 2026
yaythomas
left a comment
Contributor
There was a problem hiding this comment.
Very nice, thank you! just some nits.
hln33
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 22:00 — with
GitHub Actions
Failure
hln33
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 22:00 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
hln33
temporarily deployed
to
ai-pr-review-runtime
August 26, 2026 22:15 — with
GitHub Actions
Inactive
hln33
had a problem deploying
to
ai-pr-review-runtime
August 26, 2026 22:15 — with
GitHub Actions
Failure
hln33
commented
Aug 26, 2026
| if execution.status == "FAILED": | ||
| logger.warning("Execution failed") | ||
| return execution | ||
| if execution.status in ["TIMED_OUT", "ABORTED"]: |
Contributor
Author
There was a problem hiding this comment.
I do not think "ABORTED" is a valid execution status. Could not find any references to it in other SDKs. The API documentation also does not list "ABORTED" as being a valid execution status.
I think it should instead be "STOPPED", as that specific status is not covered in this function.
I noticed this when implementing a new "execution_status" field on the test result class and my AI coding agent flagged this to me.
Contributor
Codex AI reviewNo actionable findings. Residual risk is limited to runtime validation because tests were not executed under the review constraints. Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#656
Description of changes:
self._fail_workflow()instead ofself._complete_workflow()so that executions fail despite not having an error payloadTesting:
hatch run test:allBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.