fix: extend Lambda read_timeout, disable retries#204
Open
fix: extend Lambda read_timeout, disable retries#204
Conversation
- Introduce a shared Lambda client config with a 960s read_timeout and retries disabled - Route all Lambda client construction through a single helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#203
Description of changes:
Fixes a crash of SAM local RIE during long-running durable Lambda steps.
botocore's default
read_timeoutof 60s was being used for local-runner Lambdainvocations made by this testing library, so any durable step that ran longer
than 60s would cause a client-side
ReadTimeoutError. The defaultmax_attempts=3retry policy then re-invoked the still-running Lambda,compounding the problem.
This change routes Lambda-invocation client construction inside the library
through a single helper that applies a consistent
botocore.config.Config:read_timeout=960seconds (Lambda's 900s max runtime + headroom for networkround-trip and SAM local RIE startup).
retries={"max_attempts": 0}— client-side retries disabled.Manually tested against the reproduction in the original issue and confirmed that steps running longer than 60s don't cause a crash.
Dependencies
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.