Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Jan 5, 2026

Description of changes:

  • Added copyright header to all source files.
  • Created new Legal Notices file.
  • Created empty CHANGELOG.md file, which will be appended in future releases.
  • Changed project name to aws-cli-migrate and package name to aws_cli_migrate.
  • Made output between interactive mode and auto-output mode more consistent where possible.
  • Fix bug in interactive mode where subsequent rules were not updating the AST, leading to auto-fixes to be missed.
  • Improved testing, including a new regression test for the interactive-mode bug described above.
  • Added IDEA IDE files to .gitignore.
  • Explicitly add Python 3.13 as a supported version in pyproject.toml.
  • Updated LICENSE to match guidance.
  • Misc. refactoring for maintainability and readability.
  • Misc. changes to README.md file.

Description of tests:

  • Ran and passed all tests and linters.
  • Ran manual testing using example scripts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team January 5, 2026 21:30
@ashovlin ashovlin requested a review from hssyoo January 7, 2026 18:27
@aemous aemous changed the title Add license header to all linter source files Fix bug in linter interactive mode, and final improvements Jan 7, 2026
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just had a couple small comments.

In the future we should break these kind of PRs out into 3 separate PRs:

  1. License/changelog updates
  2. Logical changes
  3. Refactoring/cleaning up

@aemous
Copy link
Contributor Author

aemous commented Jan 8, 2026

In the future we should break these kind of PRs out into 3 separate PRs:

Will do, thank you.

@aemous aemous requested a review from hssyoo January 8, 2026 16:15
@aemous aemous merged commit 80c50b0 into aws:v1v2-migration-tool Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants