Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-sso-31940.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "``sso``",
"description": "Fix SSO login failure in the EUSC partition by adding the issuer domain ``identitycenter.amazonaws.eu`` to the SSO start URL resolver allowlist."
}
1 change: 1 addition & 0 deletions awscli/customizations/sso/resolve.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
_AWS_OWNED_EXACT = (
'identitycenter.amazonaws.com',
'identitycenter.amazonaws.com.cn',
'identitycenter.amazonaws.eu',
)

_REGION_PATTERNS = (
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/customizations/sso/test_resolve.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class TestIsAwsOwnedDomain:
'ssoins-abc123.portal.cn-north-1.app.amazonwebservices.com.cn',
'ssoins-abc123.eusc-de-east-1.portal.amazonaws.eu',
'ssoins-abc123.portal.eusc-de-east-1.api.amazonwebservices.eu',
'identitycenter.amazonaws.eu',
],
)
def test_aws_owned_returns_true(self, hostname):
Expand Down Expand Up @@ -112,6 +113,7 @@ def test_extracts_region(self, hostname, expected_region):
'd-abc123.awsapps.cn',
'identitycenter.amazonaws.com',
'identitycenter.amazonaws.com.cn',
'identitycenter.amazonaws.eu',
'aws.mycompany.com',
],
)
Expand Down
Loading