Skip to content

Add SSO_LOGIN_VANITY_URL feature ID to OIDC requests for vanity URL logins#10459

Open
AndrewAsseily wants to merge 6 commits into
v2from
fix/vanity-url-feature-id
Open

Add SSO_LOGIN_VANITY_URL feature ID to OIDC requests for vanity URL logins#10459
AndrewAsseily wants to merge 6 commits into
v2from
fix/vanity-url-feature-id

Conversation

@AndrewAsseily

Copy link
Copy Markdown
Contributor

Issue #, if available: Follow-up to #10457

Description of changes: Registers the SSO_LOGIN_VANITY_URL feature ID in the User-Agent header on SSO-OIDC requests when the login flow resolved a vanity URL to an AWS-owned endpoint.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AndrewAsseily AndrewAsseily requested a review from a team as a code owner June 30, 2026 16:49
Comment thread awscli/botocore/utils.py Outdated
Comment thread awscli/clidriver.py Outdated
def main(self, args):
try:
rc = self._do_main(args)
with start_as_current_context():

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Followed up async)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants