Skip to content

Upgrade debug mode: Add detection for default checksum algorithm breaking change#10220

Open
aemous wants to merge 2 commits intoaws:developfrom
aemous:checksum-algorithm-debug-mode
Open

Upgrade debug mode: Add detection for default checksum algorithm breaking change#10220
aemous wants to merge 2 commits intoaws:developfrom
aemous:checksum-algorithm-debug-mode

Conversation

@aemous
Copy link
Copy Markdown
Contributor

@aemous aemous commented Apr 13, 2026

Description of changes:

  • Added support to upgrade debug mode for detecting CRC32-by-default-in-v1 vs. CRC64NVME-by-default-in-v2.

Description of tests:

  • Passed all CI (including 4 new functional tests added to verify expected behavior of the new functionality).
  • Succeeded manual testing described below

Manual testing

To test the code changes, I ran the following commands:

aws s3 cp ./file.txt s3://bucket --v2-debug

I verified that the new warning is printed to STDERR.

Then, I also ran

aws s3 cp ./file.txt s3://bucket --checksum-algorithm CRC32 --v2-debug

And i verified that the new warning is not printed to STDERR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aemous added 2 commits April 6, 2026 10:41
…nal tests to verify behavior of this new feature, and add a changelog entry.
@aemous aemous requested a review from a team April 13, 2026 17:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (c4681b5) to head (92300ee).
⚠️ Report is 269 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10220      +/-   ##
===========================================
+ Coverage    93.39%   93.43%   +0.04%     
===========================================
  Files          210      210              
  Lines        17052    17237     +185     
===========================================
+ Hits         15925    16105     +180     
- Misses        1127     1132       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants