fix: read/write splitting switch to writer #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
force-pushed
the
fix/read-write-splitting-no-writer
branch
from
9217b12 to
f3c0000
Compare
sophia-bq
reviewed
Jan 20, 2026
| conn.read_only = False | ||
|
|
||
| writer_id = rds_utils.get_cluster_writer_instance_id() | ||
| new_member = writer_id |
Contributor
There was a problem hiding this comment.
why do we assign writer_id to new_member? the following lines are actually clearer if you keep the name writer_id?
Contributor
Author
There was a problem hiding this comment.
Good point, I just deleted the code path from the if else condition as the original, will change it to improve readability
Comment on lines
284
to
285
| # We should not be able to switch again because new_member was removed from the custom endpoint. | ||
| # We are connected to the reader. Attempting to switch to the writer will throw an exception. |
Contributor
There was a problem hiding this comment.
To clarify:
- reconnected back to the original reader instance on line 277
- removed the original reader instance from the custom endpoint
- now switching to the writer instance (a valid member of the endpoint) errors out
This is because the current reader connection is invalid? Wouldn't any operation fail?
Contributor
Author
There was a problem hiding this comment.
So:
- Connected to reader node, readOnly=False should fail since writer is not in allowed list
- Add writer and then switch to Writer so it should be good,
- Switch back to reader (readOnly=True), then remove writer (not original reader)
- Now try to switch to Writer and it should fail.
Contributor
Author
There was a problem hiding this comment.
I'll add something like this in the beginning of each test so it's more descriptive, and will change the variable names
faviansamatha
force-pushed
the
fix/read-write-splitting-no-writer
branch
from
f3c0000 to
349ef26
Compare
Co-authored-by: Sophia Chu <112967780+sophia-bq@users.noreply.github.com>
karenc-bq
reviewed
Jan 21, 2026
aws_advanced_python_wrapper/simple_read_write_splitting_plugin.py
Outdated
Show resolved
Hide resolved
karenc-bq
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.