Open
Conversation
karenc-bq
force-pushed
the
feat/gdb-iam
branch
3 times, most recently
from
e4d8ee8 to
8cf1954
Compare
sophia-bq
reviewed
Mar 3, 2026
| } | ||
|
|
||
| this.region = RegionUtils.getRegion(props.get(WrapperProperties.CUSTOM_ENDPOINT_REGION.name), this.customEndpointHostInfo.host); | ||
| const regionUtils = new RegionUtils(); |
Contributor
There was a problem hiding this comment.
Curious, is custom endpoint plugin incompatible with global? This doesn't seem to allow it to use the gdb region utils
Contributor
Author
There was a problem hiding this comment.
Good point, let's add the feature to custom endpoints as well
Contributor
Author
There was a problem hiding this comment.
Discussed this further offline and decided to keep this unchanged.
We will not reach this section of the code unless the URL is a custom endpoints URL. Custom endpoints URL contains proper region information, so there is no need to retrieve region information using GDBRegionUtils here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.