fix: netty mem leak during failure - #521
Open
ShubhamChaturvedi7 wants to merge 4 commits into
Open
ShubhamChaturvedi7 wants to merge 4 commits into
ShubhamChaturvedi7 wants to merge 4 commits into
Conversation
josecorella
reviewed
Oct 1, 2026
| throw new S3EncryptionClientException("Decryption materials cannot be null. " + | ||
| "This may be caused by a misconfigured custom CMM implementation or " + | ||
| "a suppressed exception from metadata decoding or CMM invocation due to a network failure."); | ||
| // Decryption setup failed in onResponse. AsyncStreamingResponseHandler#onHeaders already |
Contributor
There was a problem hiding this comment.
since we are no longer throwing this exception, how are we notifying to custoer that the decryption materials are null and that they may have a misconfigured cmm? removing this exception can be a breaking change, no?
Author
There was a problem hiding this comment.
The comments explain that - since this is async pipeline, a prev step failed and the Future has exception set. Throwing from here doesn't throw it for the callers, but rather for the pipeline. Which is exactly what was causing the memory leak.
TLDR: The caller still sees the exception - see the test case here
josecorella
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Drain the stream if a failure has occurred after fetching the payload.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: