Skip to content

fix(ci): update snapshots after CDK version sync in release workflow#848

Merged
aidandaly24 merged 1 commit intomainfrom
fix/update-snapshots-in-release-workflow
Apr 14, 2026
Merged

fix(ci): update snapshots after CDK version sync in release workflow#848
aidandaly24 merged 1 commit intomainfrom
fix/update-snapshots-in-release-workflow

Conversation

@jesseturner21
Copy link
Copy Markdown
Contributor

Summary

  • The release workflow syncs @aws/agentcore-cdk to the latest npm version in src/assets/cdk/package.json, but never updates the corresponding snapshot tests
  • This caused the test-and-build job to fail with a snapshot mismatch (0.1.0-alpha.17 in snapshot vs 0.1.0-alpha.18 in the synced file)
  • Adds a npm run test:update-snapshots step after the CDK sync and version bump, before the release branch commit

Test plan

  • Trigger the release workflow and verify the test-and-build job passes
  • Verify the snapshot update step appears in the workflow logs

The release workflow syncs @aws/agentcore-cdk to the latest npm version
but did not update the asset snapshot tests, causing the test-and-build
job to fail with a snapshot mismatch.
@jesseturner21 jesseturner21 requested a review from a team April 14, 2026 22:31
@github-actions github-actions bot added the size/xs PR size: XS label Apr 14, 2026
@aidandaly24 aidandaly24 merged commit 6f87f04 into main Apr 14, 2026
21 checks passed
@aidandaly24 aidandaly24 deleted the fix/update-snapshots-in-release-workflow branch April 14, 2026 22:31
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.8.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-848-tarball/aws-agentcore-0.8.0.tgz

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 44.58% 7063 / 15842
🔵 Statements 44.06% 7495 / 17009
🔵 Functions 42.04% 1264 / 3006
🔵 Branches 43.59% 4752 / 10900
Generated in workflow #1775 for commit 356e071 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants