feat: add --snapshot flag to npm run package#807
Draft
Hweinstock wants to merge 2 commits intoaws:mainfrom
Draft
feat: add --snapshot flag to npm run package#807Hweinstock wants to merge 2 commits intoaws:mainfrom
Hweinstock wants to merge 2 commits intoaws:mainfrom
Conversation
51a8f50 to
d8e4ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
PR tarballs from different commits all have the same version (
0.8.0), making it impossible to identify which commit a tarball came from once downloaded.Solution
Add a
packagenpm script (scripts/package.mjs) that wraps build + pack. When invoked with--snapshot, it appends the short git commit hash to the version (e.g.0.8.0-sha.abc1234) so pre-release tarballs are self-documenting. The PR tarball workflow now uses this script.Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
I ran
npm run test:unitandnpm run test:integI ran
npm run typecheckI ran
npm run lintIf I modified
src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsnpm run packageproducesaws-agentcore-0.8.0.tgznpm run package -- --snapshotproducesaws-agentcore-0.8.0-sha.6e19463.tgzpackage.jsonversion restored correctly after snapshot buildChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.