add check for kms key in token vault before create one#339
Open
jesseturner21 wants to merge 1 commit intomainfrom
Open
add check for kms key in token vault before create one#339jesseturner21 wants to merge 1 commit intomainfrom
jesseturner21 wants to merge 1 commit intomainfrom
Conversation
cac1a1a to
296b8af
Compare
296b8af to
b0d6c3d
Compare
Contributor
Coverage Report
|
b0d6c3d to
1ee642f
Compare
tejaskash
requested changes
Feb 18, 2026
Comment on lines
+97
to
+98
| const controlClient = new BedrockAgentCoreControlClient({ region, credentials }); | ||
|
|
Contributor
There was a problem hiding this comment.
NIT - Can we create a single BedrockAgentCoreControl client in https://github.com/aws/agentcore-cli/blob/main/src/cli/aws/agentcore-control.ts and move this API call there. We don't want many client initializations peppered through the codebase. Makes it easier to make config changes or debug if its all in one place
Contributor
There was a problem hiding this comment.
Same ^
Otherwise, good bug catch and thanks for the fix!
tejaskash
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the deploy command.
Every time we deploy it creates a new kms key for the token vault in identity. This is very bad as it leaves a orphaned kms keys in the users account costing $1 a month per key.
This checks if there is a kms key in token vault already and uses the one already there
Related Issue
#337
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.