test: add unit tests for TUI

[notgitika]

Description

Adds comprehensive unit test coverage for TUI components and hooks using ink-testing-library. This brings the test count from ~874 to 1623 and roughly doubles overall statement coverage (~20% → ~42%).

Components tested (25 files): AwsTargetConfigUI, ConfirmReview, CredentialSourcePrompt, Cursor, DeployStatus, FatalError, FullScreenLogView, Header, HelpText, LogLink, LogPanel, MultiSelectList, NextSteps, Panel, PathInput, PromptScreen, ResourceGraph, Screen, ScreenHeader, ScreenLayout, ScrollableList, ScrollableText, SecretInput, SelectList, SelectScreen, StepIndicator, StepProgress, TextInput, TwoColumn, WizardSelect

Hooks tested (8 files): useExitHandler, useListNavigation, useMultiSelectNavigation, useProject, useRemove, useResponsive, useSchemaDocument, useTextInput

Also includes: guards (project guard), context (LayoutContext), exit-message, and additional lib coverage for ConfigIO, errors, packaging helpers, and platform utils.

All tests use keyboard simulation (stdin.write) to verify interactive behavior (navigation, selection, input masking, scrolling, exit handling).

Type of Change

• Other (please describe): unit test coverage expansion

Testing

• I ran npm run test:all
• I ran npm run typecheck
• I ran npm run lint
• If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

• I have read the CONTRIBUTING document
• I have added any necessary tests that prove my fix is effective or my feature works
• My changes generate no new warnings
• Any dependent changes have been merged and published

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	41.29%	2656 / 6432
🔵	Statements	40.74%	2785 / 6835
🔵	Functions	43.55%	571 / 1311
🔵	Branches	46.81%	1765 / 3770

Generated in workflow #408 for commit b415def by the Vitest Coverage Report Action

[notgitika]

/strands review (no actions, only review this PR). be concise and clear

[github-actions]

Code Review Summary

Overall Assessment: Strong test coverage expansion with consistent patterns. Tests pass and achieve the stated coverage goals (20% → 42%). A few minor improvements recommended but nothing blocking.

---

✅ Strengths

1. Comprehensive Coverage: 50 new test files covering 25 components, 8 hooks, guards, context, and lib utilities
2. Consistent Patterns: All tests use ink-testing-library, vi.fn() for mocks, and standard vitest assertions
3. Interactive Testing: Excellent use of stdin.write() to simulate keyboard input (arrows, enter, escape, tab, etc.)
4. Clean Structure: Tests are well-organized, readable, and focused on single responsibilities
5. Proper Cleanup: Consistent use of afterEach(() => vi.restoreAllMocks())
6. Edge Cases: Good coverage of boundary conditions (empty lists, disabled items, wrapping, etc.)

---

🔍 Suggestions

suggestion: Consider reducing reliance on timing-based delays

• Many tests use delay(50) or delay(100) which can cause flakiness on slow CI runners
• Where possible, use event-driven waiting or consider if delays are truly necessary
• Example: src/cli/tui/components/__tests__/TextInput.test.tsx:57-62

suggestion: Some async operations missing await

• A few stdin.write() calls aren't followed by await delay() which could cause race conditions
• Example: src/cli/tui/components/__tests__/PromptScreen.test.tsx:34 - immediate assertion after write
• Consider adding delays before assertions that depend on input processing

suggestion: Mock organization could be more consistent

• Some tests use vi.hoisted() (PathInput.test.tsx:6-8)
• Others define mocks inline (useRemove.test.tsx:14-18)
• Consider standardizing on one approach for better maintainability

nit: File extension changes

• useListNavigation.test.ts → .tsx and useTextInput.test.ts → .tsx
• While valid (they now render components), worth noting this changes import resolution slightly

nit: Test consolidation

• config-extended.test.ts and config-io-extended.test.ts were removed
• Changes consolidated into main test files - verify no test cases were lost

---

✅ Verified

• All tests pass (npm run test:unit)
• Coverage increased as stated (40.74% statements)
• No new linting errors
• Follows TESTING.md guidelines (co-located tests, vitest imports, assertions)
• Tests use recommended patterns from existing codebase

---

Summary

Excellent work on comprehensive TUI test coverage! The tests are well-written, consistent, and achieve the coverage goals. The timing-dependent delays are the main concern but not blocking. Consider addressing the suggestions in a follow-up if needed.

[jesseturner21]

LGTM