test(feedback): fix root command-tree assertion broken by the feedback command - #2152
Closed
jariy17 wants to merge 1 commit into
Closed
test(feedback): fix root command-tree assertion broken by the feedback command#2152jariy17 wants to merge 1 commit into
jariy17 wants to merge 1 commit into
Conversation
The feedback command was registered on the root handler in PR #2149 but root.test.tsx's expected subcommand list was not updated, so 'builds the agentcore command tree with its subcommands' failed in CI. Add 'feedback' in its registration position (after eval).
Contributor
Author
agentcore-devx-automation
Bot
added
the
agentcore-harness-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This is a trivial one-line test update adding "feedback" to the expected list of root subcommands in src/handlers/root.test.tsx. The change is correct and low-risk.
Per the author's comment, this PR is being superseded by #2149 (cherry-picked as c25a04c), so it will likely be closed rather than merged — but nothing about the diff itself needs to change.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on #2149 fails one unit test:
createRootHandler > builds the agentcore command tree with its subcommands(src/handlers/root.test.tsx). Registering thefeedbackcommand on the root handler added a subcommand the test's hard-coded expected list didn't include ("Received +1").Fix
One line: add
"feedback"to the expectedroot.children()list, in its registration position (aftereval, beforeconfig).Notes
feat/feedback-command(the feedback-port branch), so this diff is just the test update. Merging it into that branch turns feat(feedback): port the feedback command to the refactor architecture #2149 green.bun test src/handlers/root.test.tsx→ 1 pass.