Skip to content

fix(templates): enable Google ADK observability#1773

Open
notgitika wants to merge 1 commit into
aws:mainfrom
notgitika:fix/google-adk-observability
Open

fix(templates): enable Google ADK observability#1773
notgitika wants to merge 1 commit into
aws:mainfrom
notgitika:fix/google-adk-observability

Conversation

@notgitika

@notgitika notgitika commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

Google ADK HTTP and AG-UI projects currently install the generic OpenTelemetry distro and exporter. Although their container entrypoint runs through opentelemetry-instrument, live AgentCore verification produced no spans.

This change:

  • replaces the generic OpenTelemetry dependencies with aws-opentelemetry-distro >= 0.17.0
  • keeps the dependency open-ended so the resolver can select the newest version compatible with Google ADK
  • adds regression coverage across HTTP, AG-UI, and A2A Google ADK templates
  • updates the affected asset snapshots

AWS distro 0.18.x currently requires OpenTelemetry 1.42.x while current Google ADK releases cap OpenTelemetry at 1.41.1. Fresh resolution therefore selects AWS distro 0.17.1 and OpenTelemetry 1.40.0 without requiring a stale upper pin.

Framework Scope

LangChain is already working and is not changed by this PR. Its template includes the AWS OpenTelemetry distro and explicit LangChain instrumentation from #552, #835, and #836. A live deployed LangChain invocation completed a tool call and emitted 22 spans, including invoke_agent, chat, execute_task, and execute_tool operations.

The remaining issue is specific to the Google ADK HTTP and AG-UI dependency templates.

Verification

Live runtime verification used a generated Google ADK HTTP project:

  • Before the change: the invocation reached Google ADK but emitted zero spans to aws/spans.
  • After replacing only the two generic OpenTelemetry dependencies with AWS distro 0.17.0: the same invocation emitted 18 spans.
  • The emitted spans included Google ADK invoke_agent and generate_content operations, plus correlated request/error telemetry; traces get returned 15 correlated runtime records.
  • The available Gemini key was invalid, so the model request ended with an authentication error. This still verified telemetry initialization and export on the ADK execution path; a successful model/tool invocation remains an additional end-to-end check.

Dependency and repository verification:

  • fresh uv pip compile resolution for both changed templates selected aws-opentelemetry-distro==0.17.1, google-adk==1.35.2, and OpenTelemetry API/SDK 1.40.0
  • 131 focused asset, snapshot, and regression tests passed
  • npm run build passed
  • the full unit run passed 5,911 tests; six unrelated failures caused by starting tests before the concurrent build produced dist/cli/index.mjs, plus one TUI timing failure, all passed when the two failed files were rerun after the build
  • pre-commit typecheck, lint, formatting, and secret checks passed

Related Issue

Addresses #140

Documentation PR

Not applicable; this corrects generated runtime dependencies without changing the user-facing configuration.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove the fix is effective
  • No documentation change is required
  • My changes generate no new warnings
  • No dependent changes are required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@notgitika notgitika requested a review from a team July 15, 2026 22:39
@github-actions github-actions Bot added the size/s PR size: S label Jul 15, 2026
@notgitika notgitika deployed to e2e-testing July 15, 2026 22:39 — with GitHub Actions Active
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 15, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 15, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.24.1.tgz

How to install

gh release download pr-1773-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.24.1.tgz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant