fix(templates): enable Google ADK observability#1773
Open
notgitika wants to merge 1 commit into
Open
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1773-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.24.1.tgz |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google ADK HTTP and AG-UI projects currently install the generic OpenTelemetry distro and exporter. Although their container entrypoint runs through
opentelemetry-instrument, live AgentCore verification produced no spans.This change:
aws-opentelemetry-distro >= 0.17.0AWS distro 0.18.x currently requires OpenTelemetry 1.42.x while current Google ADK releases cap OpenTelemetry at 1.41.1. Fresh resolution therefore selects AWS distro 0.17.1 and OpenTelemetry 1.40.0 without requiring a stale upper pin.
Framework Scope
LangChain is already working and is not changed by this PR. Its template includes the AWS OpenTelemetry distro and explicit LangChain instrumentation from #552, #835, and #836. A live deployed LangChain invocation completed a tool call and emitted 22 spans, including
invoke_agent,chat,execute_task, andexecute_tooloperations.The remaining issue is specific to the Google ADK HTTP and AG-UI dependency templates.
Verification
Live runtime verification used a generated Google ADK HTTP project:
aws/spans.invoke_agentandgenerate_contentoperations, plus correlated request/error telemetry;traces getreturned 15 correlated runtime records.Dependency and repository verification:
uv pip compileresolution for both changed templates selectedaws-opentelemetry-distro==0.17.1,google-adk==1.35.2, and OpenTelemetry API/SDK 1.40.0npm run buildpasseddist/cli/index.mjs, plus one TUI timing failure, all passed when the two failed files were rerun after the buildRelated Issue
Addresses #140
Documentation PR
Not applicable; this corrects generated runtime dependencies without changing the user-facing configuration.
Type of Change
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.