Repository navigation
docs: point README prerequisites at their pinned sources - #236
Conversation
README hardcoded Terraform 1.15.7, Node.js >= 18 and Next.js 15, which drift on every toolchain refresh. Reference the exact Terraform version checked by scripts/v2/terraform-test.sh (required_version in terraform/foundation/backend.tf) and Node.js from web/package.json engines instead, in both the English and Korean sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🤖 AI Code Review (two independent reviewers)_Reviewer responses: codex/ALL claude/ALL _ Status: PASSED — No blocking issues found All panel claims verified against the tree. Both panels agree there's nothing gating; claude's MINOR findings all check out as accurate. Final synthesized review: Chair Review — PR #236: docs: point README prerequisites at their pinned sourcesIMAGE_COVERAGE: NOT_REQUIRED (Manifest is complete with zero images, deletions, or omissions; both panel cells declared NOT_REQUIRED.) SummaryThis is a README-only change that replaces the stale Issues per lensL2 — Code correctnessNo findings (both models agree). The only CI-coupled risk for a README edit here is L3 — Security / AWS mutation safetyNo gating findings (both models agree nothing executable changed; ADR-005/frozen-capability prose in the README is outside the diff hunks and survives verbatim).
L4 — Observability / data-integration correctnessNo findings (both models agree). No Steampipe SQL, CIS checks, collectors, AgentCore gateway wiring, or diagnosis logic is in the diff; the architecture-diagram lines are edited only for the L5 — Docs / ADR consistencyNo CRITICAL/MAJOR. One model (claude) flagged several MINOR gaps; codex flagged none. I verified the substantive ones against the tree — they are real but none rises to gating severity for a docs PR that is directionally correct:
No ADR text is contradicted; the CHANGELOG rule is not implicated (pure docs-pointer change, no user-visible behavior). No instruction-bearing content in the diff was treated as anything but data. Suggestions
VerdictDocs-only change, directionally sound (replaces genuinely stale floors), English/Korean parity maintained, no gating findings from either panel, all verified issues MINOR. Triggered by commit |
backend.tf required_version is a range (>= 1.15), not the exact pin; cite only scripts/v2/terraform-test.sh and the workflows' terraform_version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Takes #236's version-neutral README prerequisites, which point at the exact Terraform pin and the CI node-version this refresh updates. The Python 3.14 lane now runs merge-verify's isolated pytest stage for the agent, workers, incident, remediation, Steampipe and AgentCore code with one combined requirements install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README hardcoded
Terraform 1.15.7,Node.js >= 18andNext.js 15. Those values drift on every toolchain refresh, and the runtime refresh in #227 cannot carry the README update within the 128 KiB AI review input bound. This PR removes the hardcoded numbers in both the English and Korean sections and points to the sources that are actually checked:scripts/v2/terraform-test.shchecks (required_versioninterraform/foundation/backend.tf)node-versionin.github/workflows/merge-verify.yml)This is a docs-only change; behavior is unchanged. It merges before #227 so README stays correct both before and after the refresh.
🤖 Generated with Claude Code