Skip to content

fix: stop excluding measurement fields whose names contain "id" from metric detection #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EAWRCEQA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop excluding measurement fields whose names contain "id" from metric detection #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions agentic_core/schema_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,12 @@ def _detect_metric_field(field_name, field_type, values):
if field_type not in ("integer", "float"):
return False
name_lower = field_name.lower()
# Skip ID-like numeric fields
if any(p in name_lower for p in ["_id", "id", "code", "编号", "year", "月", "日"]):
# Skip ID-like numeric fields. Match "id"/"_id" precisely (standalone name
# or "_id" suffix) instead of as a substring, otherwise measurement fields
# such as "width", "humidity" or "grid_load" are wrongly excluded.
if name_lower == "id" or name_lower.endswith("_id"):
return False
if any(p in name_lower for p in ["code", "编号", "year", "月", "日"]):
return False
return True

Expand Down