Skip to content

fix(deploy): define missing AllowedCIDR parameter in CloudFormation template #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjdMASTER wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deploy): define missing AllowedCIDR parameter in CloudFormation template #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion deploy/cfn-agentic-data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ Parameters:
Default: "10.0.0.0/16"
AllowedPattern: '(\d{1,3}\.){3}\d{1,3}/\d{1,2}'

AllowedCIDR:
Type: String
Default: "10.0.0.0/8"
AllowedPattern: '(\d{1,3}\.){3}\d{1,3}/\d{1,2}'
Description: "CIDR allowed to reach the ALB. Override with your public IP/range; never use 0.0.0.0/0."

ContainerImageUri:
Type: String
Description: "ECR image URI (account.dkr.ecr.region.amazonaws.com/repo:tag)"
Expand Down Expand Up @@ -321,11 +327,16 @@ Resources:
GroupDescription: ALB - HTTPS from allowed sources only (NO 0.0.0.0/0)
VpcId: !Ref VPC
SecurityGroupIngress:
- IpProtocol: tcp
FromPort: 80
ToPort: 80
CidrIp: !Ref AllowedCIDR
Description: "HTTP from allowed CIDRs"
- IpProtocol: tcp
FromPort: 443
ToPort: 443
CidrIp: !Ref AllowedCIDR
Description: "HTTPS from allowed CIDRs"
Description: "HTTPS from allowed CIDRs (post-deploy ACM listener)"
SecurityGroupEgress:
- IpProtocol: "-1"
CidrIp: "0.0.0.0/0"
Expand Down