refactor(event-handler): simplify HTTP event parsing - #5686
Open
svozza wants to merge 3 commits into
Open
Conversation
dreamorosi
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The way we handle the incoming lambda event has always felt suboptimal to me, this refactor centralises API Gateway v1, v2, and ALB event conversion and reuses the converted event throughout the router. This refactor has the nice side effect of removing the awkward dance we had to do around rejecting invalid HTTP methods with a fake URL request. Also, base64 bodies are decoded directly to bytes so binary uploads are no longer corrupted by UTF-8 conversion. Lastly, I realised that
proxyEventToWebRequestwas erroneously made part of the public API originally: this refactor means it is no longer needed but unfortunately we cannot remove it so it is marked deprecated.Changes
Content-Typeheader now leave it unset.proxyEventToWebRequestin favor of accessingreqCtx.reqin Router handlers or middleware.Compared with the implementation proposed in #5685:
Requestitself as the normalized representation, rather than introducingRawRequestandHttpRequestInput. Shared functions centralize normalization without additional intermediate objects.Issue number: closes #5685
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.