feat(parser): add errorHandler option for inline parse error handling#5352
Open
Zelys-DFKH wants to merge 1 commit into
Open
feat(parser): add errorHandler option for inline parse error handling#5352Zelys-DFKH wants to merge 1 commit into
Zelys-DFKH wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Changes
Adds an optional
errorHandlercallback toParserOptions, letting callers intercept parse failures and return a custom response instead of throwing.The motivation comes from #4191: when
@parseris stacked with other decorators that expect a fully-typed event,safeParse: truedoesn't compose well -- the outer decorators seeParsedResultrather than the actual payload. An error handler keeps the event type clean while still providing a recovery path on parse failure. Thanks to @codyfrisch for walking through this use case in detail.The callback receives the
ParseError. If it returns a non-undefined value, that becomes the Lambda/Middy response and stops further processing. If it returnsundefined, the original error is rethrown -- so you can handle specific failure cases without silently absorbing unexpected ones. Non-ParseErrorexceptions (e.g., from schema transforms) always propagate as-is.Both the
@parserclass decorator andparser()Middy middleware support the new option.Issue number: closes #4191
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.