feat: add TenancyConfig to ACK Lambda Controller #201
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.20.0 | ||
| name: functions.lambda.services.k8s.aws | ||
| spec: | ||
| group: lambda.services.k8s.aws | ||
|
|
@@ -365,6 +365,12 @@ spec: | |
| A list of tags (https://docs.aws.amazon.com/lambda/latest/dg/tagging.html) | ||
| to apply to the function. | ||
| type: object | ||
| tenancyConfig: | ||
|
Contributor
There was a problem hiding this comment. When adding a new field a CRD I'd expect to see some changes the files associated with our code-generator to fetch a new version of the AWS API model that includes the new field and/or remove it from a a list of ignored fields in generator.yaml. Since, this is a newer AWS feature you'll likely need to update the version of the AWS SDK used to generate the lambda-controller here to use a newer version of AWS Lambda's API model. If that results in additional fields being added that you don't want to take on in this PR you can add them to the ignored fields (see docs). |
||
| description: The function's tenant isolation configuration. | ||
| properties: | ||
| tenantIsolationMode: | ||
| type: string | ||
| type: object | ||
| timeout: | ||
| description: |- | ||
| The amount of time (in seconds) that Lambda allows a function to run before | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| apiVersion: lambda.services.k8s.aws/v1alpha1 | ||
|
Contributor
There was a problem hiding this comment. Normally there would be an e2e test associated with the resources in this folder. Could you either add a test to validate setting the tenancy config or remove this? |
||
| kind: Function | ||
| metadata: | ||
| name: $FUNCTION_NAME | ||
| annotations: | ||
| services.k8s.aws/region: $AWS_REGION | ||
| spec: | ||
| name: $FUNCTION_NAME | ||
| code: | ||
| s3Bucket: $BUCKET_NAME | ||
| s3Key: $LAMBDA_FILE_NAME | ||
| role: $LAMBDA_ROLE | ||
| runtime: python3.9 | ||
| handler: main | ||
| description: function with tenant isolation enabled | ||
| tenancyConfig: | ||
| tenantIsolationMode: "PER_TENANT" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could you use v0.19.0 here.