Skip to content

Add support for ManagedPrefixLists in EC2 controller #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add support for ManagedPrefixLists in EC2 controller #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8bb8de5
Add support for ManagedPrefixLists in EC2 controller
alexcristi Oct 29, 2025
834413f
Fix templates
alexcristi Oct 29, 2025
9396c33
Fix filter logic
alexcristi Oct 30, 2025
197b2d0
Update integration tests
alexcristi Oct 30, 2025
c085efd
Update integration tests - fix status assertion too early
alexcristi Oct 30, 2025
1b566d5
Integrate CR feedback - integration tests update
alexcristi Oct 30, 2025
5ee025c
Wait on condition ACK.ResourceSynced on update test
alexcristi Oct 30, 2025
873ebd1
Integrate CR feedback - code cleanup
alexcristi Oct 31, 2025
88e3db6
Integrate CR feedback - tags
alexcristi Oct 31, 2025
bcf7f95
Integrate CR feedback - use prefixListID as the only filter
alexcristi Nov 5, 2025
2219e73
Add managedprefixlists to role-reader/writer helm templates
alexcristi Nov 7, 2025
1306caf
Regenerated with the correct versions
alexcristi Nov 7, 2025
3e36e28
Regenerated with v0.16.2
alexcristi Nov 7, 2025
510b3ce
Regenerate with default upstream settings
alexcristi Nov 8, 2025
031e6f1
Integrate CR feedback by michaelhtm
alexcristi Nov 11, 2025
515e4b9
Update test data
alexcristi Nov 11, 2025
8770385
Refactor hooks code
alexcristi Nov 12, 2025
21d8afb
Fix update logic
alexcristi Nov 12, 2025
81220a0
Integrate CR feedback - use is_arn
alexcristi Nov 12, 2025
7029c02
Regenerate after rebase
alexcristi Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-11-12T23:05:25Z"
build_date: "2025-11-13T15:03:08Z"
build_hash: c833f2d14f4fe8953663ff92f4661ae5fb01b8c8
go_version: go1.25.4
version: v0.53.1
api_directory_checksum: 5a5c93e3d4865ea08d8a47b2500551112ea831b9
api_directory_checksum: 367f0bfdcd7ddb142c0b59b0ad45288f08abebeb
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 220d17205c72ce425824ef99e0a79fbfc7c63ef2
file_checksum: d0d6d33a5d05c555ed4539c7c19e82bbc63de468
original_file_name: generator.yaml
last_modification:
reason: API generation
83 changes: 82 additions & 1 deletion apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ ignore:
- CreateLaunchTemplateInput.ClientToken
- CreateLaunchTemplateInput.TagSpecifications
- CreateLaunchTemplateVersionInput.LaunchTemplateData.TagSpecifications
- CreateManagedPrefixListInput.ClientToken
- CreateManagedPrefixListInput.TagSpecifications
- CreateManagedPrefixListInput.DryRun
- CreateLaunchTemplateVersionOutput.LaunchTemplateVersion.DefaultVersion
resource_names:
- CapacityReservationBySplitting
Expand Down Expand Up @@ -150,7 +153,7 @@ ignore:
- LocalGatewayRouteTableVpcAssociation
- LocalGatewayRouteTableVirtualInterfaceGroupAssociation
- LocalGatewayRoute
- ManagedPrefixList
#- ManagedPrefixList
#- NatGateway
- NetworkAclEntry
#- NetworkAcl
Expand Down Expand Up @@ -230,6 +233,8 @@ operations:
resource_name: LaunchTemplate
DescribeLaunchTemplates:
custom_check_required_fields_missing_method: checkForMissingRequiredFields
DescribeManagedPrefixLists:
custom_check_required_fields_missing_method: checkForMissingRequiredFields
CreateNatGateway:
output_wrapper_field_path: NatGateway
CreateNetworkAcl:
Expand Down Expand Up @@ -612,6 +617,82 @@ resources:
template_path: hooks/nat_gateway/sdk_file_end.go.tpl
update_operation:
custom_method_name: customUpdateNATGateway
ManagedPrefixList:
exceptions:
terminal_codes:
- InvalidParameterValue
- PrefixListMaxEntriesExceeded
Copy link
Member

@michaelhtm michaelhtm Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this error should be terminal..does this error require the user to change the spec of the resource?

Copy link
Author

@alexcristi alexcristi Nov 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. I was under the impression that once we set the prefix list max entries at creation time we cannot change that anymore. Just realized there is a "resize" feature on that in AWS, so yes, this will require the user to change the spec of the resource.

renames:
operations:
CreateManagedPrefixList:
input_fields:
PrefixListName: Name
output_fields:
PrefixListId: ID
DescribeManagedPrefixLists:
input_fields:
PrefixListIds: ID
output_fields:
PrefixListId: ID
ModifyManagedPrefixList:
input_fields:
PrefixListId: ID
PrefixListName: Name
output_fields:
PrefixListId: ID
DeleteManagedPrefixList:
input_fields:
PrefixListId: ID
fields:
ID:
is_primary_key: true
is_read_only: true
print:
path: Status.ID
name: ID
Name: {}
State:
is_read_only: true
print:
path: Status.State
name: STATE
Version:
is_read_only: true
print:
path: Status.Version
name: VERSION
PrefixListARN:
is_arn: true
Entries:
custom_field:
list_of: AddPrefixListEntry
compare:
is_ignored: false
Tags:
from:
operation: CreateTags
path: Tags
synced:
when:
- path: Status.State
in:
- create-complete
- create-failed
- modify-complete
- modify-failed
- restore-complete
- restore-failed
- delete-complete
- delete-failed
hooks:
sdk_create_post_build_request:
template_path: hooks/managed_prefix_list/sdk_create_post_build_request.go.tpl
sdk_read_many_post_build_request:
template_path: hooks/managed_prefix_list/sdk_read_many_post_build_request.go.tpl
sdk_read_many_post_set_output:
template_path: hooks/managed_prefix_list/sdk_read_many_post_set_output.go.tpl
update_operation:
custom_method_name: customUpdateManagedPrefixList
RouteTable:
fields:
# RouteStatuses as Route to ensure
Expand Down
101 changes: 101 additions & 0 deletions apis/v1alpha1/managed_prefix_list.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading