fix: correct union type code generation for list members #629
Conversation
Fix code generation for union types with list members (e.g []*string) that was incorrectly trying to dereference the constructed slice and assign directly to non-existent interface fields.
a-hilaly
added
the
do-not-merge/hold
|
Just hacking around - not ready for a review. |
|
/retest |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a-hilaly
removed
the
do-not-merge/hold
|
@knottnt @rushmash91 can you please take a look? |
|
/hold Adding hold for unit tests. Assuming there is a AWS service that requires these changes for a CRD to be generated correctly. Should add it to test data with a minimal generator.yaml recreating the necessary field config. |
ack-prow
bot
added
the
do-not-merge/hold
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
merged commit e559791
into
aws-controllers-k8s:main
3 participants
Fix code generation for union types with list members (e.g []*string) that was incorrectly trying to dereference the constructed slice and assign directly to non-existent interface fields.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.