fix: remove message array mutations during abort to prevent state corruption#350
Closed
avoidwork wants to merge 1 commit into
Closed
fix: remove message array mutations during abort to prevent state corruption#350avoidwork wants to merge 1 commit into
avoidwork wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed message array mutations in abort/error handlers that could corrupt state when the server returns a 400 response. The AbortError catch block in handleChat/handleCommand now handles cleanup instead.
Type of Change
Testing
Tests pass (1149/1150, 1 skipped). Pre-commit hooks (lint, format, coverage) all pass.
Coverage
Checklist
npm run lintpasses