fix: harden input validation and edge-case handling in filesize() - #344
Merged
Merged
Conversation
- Unify BigInt and number input paths so overflowing BigInts throw TypeError - Coerce string exponent to number so SI special case resolves correctly - Floor non-integer positive exponents to prevent NaN from table indexing - Use Math.abs for singular/plural so -1 uses singular unit name - Preserve sign when a negative value rounds to zero - Validate precision range (1-100) and throw clean TypeError - Validate output option and throw TypeError for invalid values - Expand scientific notation to full decimal to prevent e+ notation leak - Document input coercion contract and option precedence in JSDoc - Add regression tests for all 57 confirmed edge cases
This was referenced Sep 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #343 — hardens
filesize()input validation and edge-case handling across all 57 confirmed edge cases.Changes
Input validation
TypeErrorinstead of returning"Infinity YB".1.5) are floored to a valid integer instead of producing"NaN undefined"."1") are coerced to a number so the SI special case resolves correctly ("1 kB"not"1 KB").precisionis validated to 1-100, throwing a cleanTypeErrorinstead of a rawRangeError.outputvalues throwTypeErrorinstead of silently returning a string.Formatting
-1now uses the singular unit name ("-1 byte"not"-1 bytes").Number.MAX_VALUEno longer leake+284notation.Documentation
Testing
Related