#1116 | Enhance concept screen to display form, section, and question… #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1vyanshu-kumar
commented
Jun 25, 2024
d1vyanshu-kumar
commented
…nd question names
vinayvenu
requested changes
Jun 26, 2024
Member
vinayvenu
left a comment
vinayvenu
left a comment
There was a problem hiding this comment.
It is best to get the group information directly from the form instead of calling the /exports for every form usage.
Also, we need to figure out errors will affect the page instead of silently swallowing them
| }); | ||
| } | ||
| } catch (error) { | ||
| console.error("Error fetching usage data:", error); |
Member
There was a problem hiding this comment.
What happens if the method fails? Will the screen still work?
|
|
||
| if (usageResponse.data.forms) { | ||
| usageResponse.data.forms.forEach(form => { | ||
| fetchFormData(form.formUUID); |
Member
There was a problem hiding this comment.
instead of doing this, why not enhance the /web/concept/usage url to give you all the data instead?
ombhardwajj
force-pushed
the
master
branch
7 times, most recently
from
2b98263 to
cafa6d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.