-
Notifications
You must be signed in to change notification settings - Fork 4
Warn on No Constraints #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
#333 is not clear yet as to the motivations yet. It isn't clear to me why we are doing this and what the implications are. |
|
warning when you have no constraints is common sense |
This to me is a fairly significant behaviour change / bug fix. As such it really needs to be in it's own PR with it's own title rather than part of "Warn on No Constraints". I think we need to split that out into a separate PR. Edit: Note that it wasn't actually a behaviour change, but instead just generated extra code that was never used. I interpreted that part incorrectly. |
I fail to understand, if a field/TYPE_USE field is not annotated with @Valid there is no circumstance where it should have an adapter generated. The adapter would just be unused because there is no code path where it is called
|
part of #333