Add KEEP mutate surface for bound node/edge writes - #113
Merged
Merged
Conversation
Closes #112. Dedicated spl mutate / spl_mutate applies one ops batch through existing ctxgit Stage/Commit (short-lived spool/mcp/… branch + PR). Bound-only FindBind fail-closed. Golden KEEP lists include mutate; REMOVE still excludes add/commit/status/branch/switch. Co-authored-by: Werner Swart <werner@swart.io>
pewpewpotato
marked this pull request as ready for review
September 19, 2026 18:30
Use --operations (file or stdin) instead of --batch, return WriteResult written/deleted, no-op identical diffs without an empty PR, and lock mutate against add/commit/status/stage/write aliases. Co-authored-by: Werner Swart <werner@swart.io>
pewpewpotato
commented
Sep 19, 2026
pewpewpotato
left a comment
pewpewpotato
left a comment
Contributor
Author
There was a problem hiding this comment.
Architecture review (#112 design)
Checked against the normative design comment on #112.
Matches
- Naming: CLI
mutate/ MCPspl_mutate; empty aliases; noadd/commit/status/stage/writereopen (golden +TestMutateHasNoVCSAliases). - Authority: thin
Session.Mutateone-shot over existingStagethenCommit— no new SoT; private Stage/Commit stay library. - Behaviour: FindBind fail-closed; empty batch rejected; short-lived
spool/mcp/…+ PR; identical diff → no empty PR; projection rebuild; leftover.splpacks untouched; protected branch not push-cleaned. - KEEP surface:
internal/surface+ help/tools/list goldens updated;schema migrateremains schema-first. - Contract: ops batch uses
MutationOperation; result embedsWriteResult(branch/commit/pullRequest/written/deleted).
Architect: no design block. (Formal APPROVE blocked — same GitHub author as the PR; treat this COMMENT as sign-off.) Merge when remaining check is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.
Implements the Architecture design comment on #112 as source of truth (comment).
Surface
spl mutate --operations <file|->(stdin via-)spl_mutate{ "operations": [...], "author"?, "message"? }add/commit/status/stage/writemutate/spl_mutate; REMOVE still excludesadd/commit/…Behaviour
FindBindfail-closed (ErrUnbound)MutationOperationshape as schema migrate / private Stage) → existingctxgitStage then Commit →spool/mcp/<stamp>-<nonce>+ PR.splpacks/CAS/gc; never push protected branchWriteResult:branch,commit,pullRequest,written,deletedschema migratestays schema-first. Mutate is graph-first.make checkis green locally (GOTOOLCHAIN=go1.26.8). Architect review as requested.