Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cmd/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ func isCanceled(err error) bool {
}

func openRestoreFile(filename string) (*os.File, int64, error) {
if filename == "" {
if filename == "" || filename == "-" {
log.Trace().Str("filename", "(stdin)").Send()
return os.Stdin, -1, nil
}
Expand Down
82 changes: 82 additions & 0 deletions internal/cmd/backup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,88 @@ func TestBackupRestoreCmdFunc(t *testing.T) {
require.Equal(t, "test/resource:1#reader@test/user:1", tuple.MustV1StringRelationship(rrResp.Relationship))
}

func TestOpenRestoreFile(t *testing.T) {
tmpDir := t.TempDir()
tmpFile, err := os.CreateTemp(tmpDir, "backup-*.zed")
if err != nil {
t.Fatalf("failed to create temp file for testing: %v", err)
}

dummyContent := []byte("dummy-data")
if _, err := tmpFile.Write(dummyContent); err != nil {
t.Fatalf("failed to write to temp file: %v", err)
}
err = tmpFile.Close()
if err != nil {
t.Fatalf("failed to close file: %v", err)
}

tests := []struct {
name string
filename string
expectError bool
expectedSize int64
}{
{
name: "empty filename defaults to stdin",
filename: "",
expectError: false,
expectedSize: -1,
},
{
name: "dash filename defaults to stdin",
filename: "-",
expectError: false,
expectedSize: -1,
},
{
name: "valid file returns file descriptor and correct size",
filename: tmpFile.Name(),
expectError: false,
expectedSize: int64(len(dummyContent)),
},
{
name: "invalid file returns error",
filename: "nonexistent_file.zed",
expectError: true,
expectedSize: 0,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
f, size, err := openRestoreFile(tt.filename)

if f != nil && f != os.Stdin {
defer func(f *os.File) {
err := f.Close()
if err != nil {
t.Fatalf("failed to close file: %v", err)
}
}(f)
}

if tt.expectError {
if err == nil {
t.Errorf("expected error, got nil")
}
} else {
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if size != tt.expectedSize {
t.Errorf("expected size %d, got %d", tt.expectedSize, size)
}
if tt.filename == "" || tt.filename == "-" {
if f != os.Stdin {
t.Errorf("expected os.Stdin")
}
}
}
})
}
}

func TestPrintBackupFileLocation(t *testing.T) {
previous := console.Errorf
t.Cleanup(func() {
Expand Down
Loading