-
Notifications
You must be signed in to change notification settings - Fork 0
Update Github actions, Agents.md, tooling, dependencies #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sanchitmehta94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| - name: Run tests | ||
| uses: mxcl/xcodebuild@e366f14791346edb74397fe9a762ccee86eddc06 # pin@v3.4.0 | ||
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pin@v3.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have two separate hash for the same pinned version ? I think version might have changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked all the places. Hash for the pinned version 3.4.0 is same across d3ee9b419c1be9a988086c58fe0988f32d99cfc5 @pmathew92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash is correct but the version you have tagged is wrong. The above hash is for version 3.6.0
https://github.com/mxcl/xcodebuild/releases/tag/v3.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs comprehensive maintenance updates across GitHub Actions workflows, dependency management, tooling configurations, and repository governance. The changes modernize the build infrastructure by updating action versions, add repository governance artifacts (CODEOWNERS, SCA workflow, AGENTS guidelines), update the Auth0 SDK dependency to version 2.16.1, raise the macOS deployment target to 14, and consolidate utility sources for better organization.
Key Changes
- Updated GitHub Actions to newer versions (checkout@v6, cache@v5, ruby/setup-ruby@v1.268.0) and corrected runner versions from non-existent macos-26 to macos-15
- Raised Auth0 SDK dependency to 2.16.1 and increased macOS deployment target from 13 to 14 across Package.swift, Cartfile, and podspec
- Added repository governance with CODEOWNERS file, SCA security scanning workflow, and comprehensive AGENTS.md documentation for AI coding assistants
Reviewed changes
Copilot reviewed 25 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| opslevel.yml | Added new repository governance configuration file |
| AGENTS.md | Added comprehensive AI agent guidelines document (928 lines) |
| .github/CODEOWNERS | Added code ownership assignment |
| .github/workflows/sca_scan.yml | Added Snyk SCA security scanning workflow |
| .github/workflows/main.yml | Updated runner from macos-26 to macos-15, updated actions to v6 |
| .github/workflows/rl-scanner.yml | Updated checkout action to v6 |
| .github/actions/test/action.yml | Updated cache to v5, updated xcodebuild action SHA |
| .github/actions/setup/action.yml | Updated ruby setup to v1.268.0, updated xcodebuild action SHA |
| Package.swift | Updated Auth0 dependency to 2.16.1, raised macOS target to v14 |
| Cartfile | Updated Auth0 dependency from master branch to 2.16.1 tag |
| Cartfile.resolved | Updated Auth0.swift resolution to 2.16.1 |
| Auth0UIComponents.podspec | Updated Auth0 dependency to 2.16.1, raised macOS target to 14.0 |
| fastlane/Fastfile | Changed repository name from 'Auth0UIComponents.swift' to 'ui-components-ios' |
| .gitignore | Improved Auth0.plist ignore patterns with wildcards |
| AppUIComponents/Auth0.plist | Deleted sample configuration file containing test credentials |
| Auth0UIComponentsTests/Utilities/Auth0UIComponentError.swift | Renamed parameter variables from abbreviated to descriptive names |
| Auth0UIComponentsTests/SavedAuthenticators/*.swift | Improved code formatting by breaking long parameter lists |
| Auth0UIComponentsTests/RecoveryCode/*.swift | Improved code formatting by breaking long parameter lists |
| Auth0UIComponents/TOTPPushEnrollment/Presentation/*.swift | Improved code formatting by extracting long inline request objects |
| Auth0UIComponents/RecoveryCode/Presentation/*.swift | Improved code formatting by extracting long inline request objects |
| Auth0UIComponents/EmailSMSEnrollment/Presentation/*.swift | Improved code formatting by extracting long inline request objects |
| Auth0UIComponents/Core/Utils/*.swift | Added new utility files (Toast, NavigationStore, ErrorScreen, CountryPicker, BundleResolver, Error handling) |
| Auth0UIComponents/Core/Utils/OTPTextField.swift | Renamed String extension methods from underscore-prefixed to standard names |
| Auth0UIComponents.xcodeproj/project.pbxproj | Updated signing configuration, removed RealityKitContent dependency, added test target dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Run tests | ||
| uses: mxcl/xcodebuild@e366f14791346edb74397fe9a762ccee86eddc06 # pin@v3.4.0 | ||
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pin@v3.4.0 |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Actions pin comment references version v3.4.0, but the commit SHA has been updated. Please verify that the new commit SHA (d3ee9b419c1be9a988086c58fe0988f32d99cfc5) actually corresponds to the v3.4.0 tag of mxcl/xcodebuild, or update the comment to reflect the correct version.
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pin@v3.4.0 | |
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pinned to specific commit d3ee9b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the correct version number to 3.6.0
|
|
||
| - name: Setup Xcode | ||
| uses: mxcl/xcodebuild@e366f14791346edb74397fe9a762ccee86eddc06 # pin@v3.4.0 | ||
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pin@v3.4.0 |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Actions pin comment references version v3.4.0, but the commit SHA has been updated. Please verify that the new commit SHA (d3ee9b419c1be9a988086c58fe0988f32d99cfc5) actually corresponds to the v3.4.0 tag of mxcl/xcodebuild, or update the comment to reflect the correct version.
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pin@v3.4.0 | |
| uses: mxcl/xcodebuild@d3ee9b419c1be9a988086c58fe0988f32d99cfc5 # pinned to d3ee9b419c1be9a988086c58fe0988f32d99cfc5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the correct version number to 3.6.0
Package.swift
Outdated
| products: [.library(name: "Auth0UIComponents", targets: ["Auth0UIComponents"])], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/auth0/Auth0.swift.git", branch:"master") | ||
| .package(url: "https://github.com/auth0/Auth0.swift.git", branch:"2.16.1") |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency specification in Package.swift is using a branch name instead of a version specifier. The value "2.16.1" should be specified using .exact("2.16.1") or .upToNextMinor(from: "2.16.1") instead of branch:. Using a branch name that looks like a version tag is misleading and may cause confusion or build issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid suggestion, branches specific to versions are mutable hence error prone and code compilation would be problematic in future (if branch gets deleted or a breaking change is pushed). Versions are immutable and accurate.
| "CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development"; | ||
| CODE_SIGN_STYLE = Automatic; | ||
| CODE_SIGN_ENTITLEMENTS = AppUIComponents/AppUIComponents.entitlements; | ||
| CODE_SIGN_IDENTITY = "Apple Development: nandan.prabhup@okta.com (28U95KH38S)"; |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding a specific developer's code signing identity is inappropriate for a shared repository. The CODE_SIGN_IDENTITY should remain as a generic value like "Apple Development" or be parameterized, not set to a specific developer's email address.
| CODE_SIGN_IDENTITY = "Apple Development: nandan.prabhup@okta.com (28U95KH38S)"; | |
| CODE_SIGN_IDENTITY = "Apple Development"; |
| apiCallInProgress = true | ||
| do { | ||
| let apiCredentials = try await dependencies.tokenProvider.fetchAPICredentials(audience: dependencies.audience, scope: "openid create:me:authentication_methods") | ||
| if type == .sms, let phoneNumber = selectedCountry?.code.appending(phoneNumber) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using switch-case instead of if-else?
| errorMessage = nil | ||
| do { | ||
| let apiCredentials = try await dependencies.tokenProvider.fetchAPICredentials(audience: dependencies.audience, scope: "openid create:me:authentication_methods") | ||
| if type == .totp, let totpEnrollmentChallenge { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch-case instead of if-else would be better to make the code cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies.tokenProvider.store(apiCredentials: APICredentials(from: credentials), for: dependencies.audience) this line is throwing a warning in Xcode (using Swift 5) as well and in Swift 6 it will give an error. Better to use await here to fix this.
Package.swift
Outdated
| products: [.library(name: "Auth0UIComponents", targets: ["Auth0UIComponents"])], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/auth0/Auth0.swift.git", branch:"master") | ||
| .package(url: "https://github.com/auth0/Auth0.swift.git", branch:"2.16.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid suggestion, branches specific to versions are mutable hence error prone and code compilation would be problematic in future (if branch gets deleted or a breaking change is pushed). Versions are immutable and accurate.
Update tooling configs and deps
📋 Changes
xcpretty, and improved Carthage caching plus switched test runs tomxcl/xcodebuild@v2.AppUIComponents/Auth0.plistand expanding.gitignoreto cover allAuth0.plistinstances while keeping the test fixture.2.16.1, aligned Carthage/SwiftPM sources, and bumped the macOS deployment target to 14 across the podspec, package manifest, and Xcode project (including signing/profile adjustments and removal of the unused RealityKitContent package).Auth0UIComponents/Core/Utils/without code changes for better organization.📎 References
None.
🎯 Testing
Manually tested flows in iPhone 16 iOS 26.2
Not run (CI will validate).