feat(mfa): Implement Multi-Factor Authentication (MFA) support#1517
Open
subhankarmaiti wants to merge 10 commits intomasterfrom
Open
feat(mfa): Implement Multi-Factor Authentication (MFA) support#1517subhankarmaiti wants to merge 10 commits intomasterfrom
subhankarmaiti wants to merge 10 commits intomasterfrom
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pmathew92
reviewed
Apr 23, 2026
| } | ||
|
|
||
| @ReactMethod | ||
| override fun mfaGetAuthenticators(mfaToken: String, factorsAllowed: ReadableArray?, promise: Promise) { |
Contributor
There was a problem hiding this comment.
Rename to getMfaAuthenticators ?
Contributor
There was a problem hiding this comment.
mfaGetAuthenticators Shouldn't this also be renamed to getMfaAuthenticators
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pmathew92
reviewed
Apr 29, 2026
| @@ -177,6 +181,7 @@ class A0Auth0Module(private val reactContext: ReactApplicationContext) : A0Auth0 | |||
|
|
|||
| this.useDPoP = useDPoP ?: true | |||
Contributor
There was a problem hiding this comment.
completely unrelated but shouldn't the default behaviour for Dpop be false ?
pmathew92
reviewed
Apr 29, 2026
| override fun mfaVerify(mfaToken: String, type: String, code: String, bindingCode: String?, promise: Promise) { | ||
| mfaBridge?.verify(mfaToken, type, code, bindingCode, promise) | ||
| ?: promise.reject("NOT_INITIALIZED", "Auth0 not initialized") | ||
| } |
Contributor
There was a problem hiding this comment.
Noted you are following a pattern of mfa prefix . Ensure this is inline with what the auth0/react SDK also follows to maintain consistency ?
pmathew92
reviewed
Apr 29, 2026
| } | ||
|
|
||
| fun getAuthenticators(mfaToken: String, factorsAllowed: ReadableArray?, promise: Promise) { | ||
| val mfaClient = createAuthClient().mfaClient(mfaToken) |
Contributor
There was a problem hiding this comment.
Can't we just create one instance on AuthenticationAPIClient for this entire class ?
private val client by lazy { AuthenticationAPIClient(auth0).apply{
if (useDPoP) {
useDPoP(reactContext)
}
}
}
pmathew92
reviewed
Apr 29, 2026
| ) | ||
| } | ||
|
|
||
| fun enroll(mfaToken: String, type: String, value: String?, promise: Promise) { |
Contributor
There was a problem hiding this comment.
Define type as enum so that its always limited to the supported factor
pmathew92
reviewed
Apr 29, 2026
| applicationId "com.auth0example" | ||
| minSdkVersion rootProject.ext.minSdkVersion | ||
| targetSdkVersion rootProject.ext.targetSdkVersion | ||
| manifestPlaceholders = [auth0Domain: "dev-481o0jxuhhma72l4.us.auth0.com", auth0Scheme: "${applicationId}.auth0"] |
Contributor
There was a problem hiding this comment.
remove the domain value from here
pmathew92
reviewed
Apr 29, 2026
| self.useDPoP = useDPoP | ||
| } | ||
|
|
||
| private func createAuthentication() -> Authentication { |
Contributor
There was a problem hiding this comment.
Same comment as in Android. Can't we have 1 instance on Authentication fot this bridge class
pmathew92
reviewed
Apr 29, 2026
| } | ||
| } | ||
|
|
||
| func enroll(mfaToken: String, type: String, value: String?, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { |
Contributor
There was a problem hiding this comment.
Make type as an enum instead of String
subhankarmaiti
force-pushed
the
feat/flexible-factors-grant-support
branch
from
71772d0 to
714794d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.