Skip to content

test: cover null claim names, zero leeway and null audience in JWTVerifier #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renanmpimentel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: cover null claim names, zero leeway and null audience in JWTVerifier #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions lib/src/test/java/com/auth0/jwt/JWTVerifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,21 @@ public void shouldThrowWhenExpectedEmptyList() {
assertThat(e.getClaimValue().asString(), is("wide audience"));
}

@Test
public void shouldThrowWhenExpectedNullAudienceButTokenHasAudience() {
IncorrectClaimException e = assertThrows(null, IncorrectClaimException.class, () -> {
// Token 'aud': 'wide audience'
String token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJ3aWRlIGF1ZGllbmNlIn0.c9anq03XepcuEKWEVsPk9cck0sIIfrT6hHbBsCar49o";
JWTVerifier.init(Algorithm.HMAC256("secret"))
.withAudience((String[]) null)
.build()
.verify(token);
});
assertThat(e.getMessage(), is("The Claim 'aud' value doesn't contain the required audience."));
assertThat(e.getClaimName(), is(RegisteredClaims.AUDIENCE));
assertThat(e.getClaimValue().asString(), is("wide audience"));
}

@Test
public void shouldNotReplaceWhenMultipleChecksAreAdded() {
JWTVerifier verifier = JWTVerifier.init(Algorithm.HMAC256("secret"))
Expand All @@ -345,6 +360,26 @@ public void shouldThrowOnNullCustomClaimName() {
.withClaim(null, "value");
}

@Test
public void shouldThrowOnNullCustomClaimNameForEveryValueType() {
Verification verification = JWTVerifier.init(Algorithm.HMAC256("secret"));

assertNullCustomClaimNameThrows(() -> verification.withClaim(null, true));
assertNullCustomClaimNameThrows(() -> verification.withClaim(null, 123));
assertNullCustomClaimNameThrows(() -> verification.withClaim(null, 123L));
assertNullCustomClaimNameThrows(() -> verification.withClaim(null, 1.5));
assertNullCustomClaimNameThrows(() -> verification.withClaim(null, Instant.now()));
assertNullCustomClaimNameThrows(() -> verification.withClaim(null, (claim, decodedJWT) -> true));
assertNullCustomClaimNameThrows(() -> verification.withArrayClaim(null, "value"));
assertNullCustomClaimNameThrows(() -> verification.withArrayClaim(null, 1, 2));
assertNullCustomClaimNameThrows(() -> verification.withArrayClaim(null, 1L, 2L));
}

private static void assertNullCustomClaimNameThrows(org.junit.function.ThrowingRunnable runnable) {
IllegalArgumentException e = assertThrows(null, IllegalArgumentException.class, runnable);
assertThat(e.getMessage(), is("The Custom Claim's name can't be null."));
}

@Test
public void shouldThrowWhenExpectedArrayClaimIsMissing() {
MissingClaimException e = assertThrows(null, MissingClaimException.class, () -> {
Expand Down Expand Up @@ -671,6 +706,20 @@ public void shouldThrowOnNegativeCustomLeeway() {
.acceptLeeway(-1);
}

@Test
public void shouldAcceptZeroLeeway() {
Algorithm algorithm = mock(Algorithm.class);
JWTVerifier.BaseVerification verification = (JWTVerifier.BaseVerification) JWTVerifier.init(algorithm)
.acceptLeeway(0)
.acceptExpiresAt(0)
.acceptNotBefore(0)
.acceptIssuedAt(0);

assertThat(verification.getLeewayFor(RegisteredClaims.EXPIRES_AT), is(0L));
assertThat(verification.getLeewayFor(RegisteredClaims.NOT_BEFORE), is(0L));
assertThat(verification.getLeewayFor(RegisteredClaims.ISSUED_AT), is(0L));
}

// Expires At

@Test
Expand Down