fix: universal components delete roles ui preview fix - #1771
Open
chakrihacker wants to merge 2 commits into
Open
fix: universal components delete roles ui preview fix#1771chakrihacker wants to merge 2 commits into
chakrihacker wants to merge 2 commits into
Conversation
Contributor
|
make sure you submit this for review in #authn-docs-management-prs on slack :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Remove Roles button overflowing outside the component boundary in the
OrganizationMemberDetailroles tab. On the docs preview's narrow column width, the destructive "Remove Roles" button spilled past the card's right edge. The root cause was a flex min-content sizing issue in the component itself, so the fix was made upstream in@auth0/universal-components-reactand pulled into the docs bundle:flex-wrapon the header row,min-w-0on the title block, andshrink-0on the action group — so the actions wrap cleanly and stay inside the card.Bundling in the updated
reacttarball surfaced a second issue that this PR also addresses:permissionsobject (gatingcanRemoveRole/canAssignRole/canRemoveFromOrganization), which the preview mocks didn't supply, causingUncaught TypeError: Cannot read properties of undefined. Added an all-truepermissionsobject to bothorganization-member-detail-mock.tsandorganization-member-management-mock.ts.core+reacttarballs and regenerated the UMD bundle served frommain/ui/universal-components/.References
https://auth0team.atlassian.net/browse/UIC-1496
Testing
mint devinmain/, open the OrganizationMemberDetail component page.Checklist
CONTRIBUTING.md.