Skip to content

Updated to JDK 21, gradle 8, fixed tests#156

Open
TareqK wants to merge 3 commits intoauth0:masterfrom
TareqK:master
Open

Updated to JDK 21, gradle 8, fixed tests#156
TareqK wants to merge 3 commits intoauth0:masterfrom
TareqK:master

Conversation

@TareqK
Copy link

@TareqK TareqK commented May 16, 2025

Changes

This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 21, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.

References

solves #111

Re-Does #138 because the company that forked it is no longer active.

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of Java or why not

Checklist

Added Context

This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.

@TareqK TareqK requested a review from a team as a code owner May 16, 2025 18:39
@TareqK TareqK mentioned this pull request May 16, 2025
5 tasks
@mammer42
Copy link

Any news when this might get merged?

@TareqK
Copy link
Author

TareqK commented Oct 10, 2025

Ive gone ahead and fixed the conflict

@tanya732
Copy link
Contributor

Hi @TareqK

Apologies for the delay on this PR. I understand it's been a long wait, and I appreciate your patience and the effort you've put in both with this PR and the earlier #138.

Moving away from Java 8 and javax.servlet is a major breaking change for this library. We needed to gather usage metrics, evaluate the impact on downstream consumers, before committing to dropping Java 8 support. That decision process took longer than any of us would have liked.

We've now made the call: Java 17 will be the new baseline for this library, along with Jakarta Servlet upgrades. I've
raised PR #207 on top of your work to complete the migration to the Jakarta namespace along with Gradle 8.

Thank you again for driving this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants