You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 21, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.
All existing and new tests complete without errors
Added Context
This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.
Apologies for the delay on this PR. I understand it's been a long wait, and I appreciate your patience and the effort you've put in both with this PR and the earlier #138.
Moving away from Java 8 and javax.servlet is a major breaking change for this library. We needed to gather usage metrics, evaluate the impact on downstream consumers, before committing to dropping Java 8 support. That decision process took longer than any of us would have liked.
We've now made the call: Java 17 will be the new baseline for this library, along with Jakarta Servlet upgrades. I've
raised PR #207 on top of your work to complete the migration to the Jakarta namespace along with Gradle 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 21, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.
References
solves #111
Re-Does #138 because the company that forked it is no longer active.
Testing
Checklist
Added Context
This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.