fix: exclude third-party client grants when AUTH0_EXCLUDE_THIRD_PARTY_CLIENTS is enabled
#1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- src/tools/auth0/handlers/clientGrants.ts: add logic to filter out third-party client grants when AUTH0_EXCLUDE_THIRD_PARTY_CLIENTS is enabled - test/tools/auth0/handlers/clientGrants.tests.js: add tests for excluding third-party client grants in getType and ensure they are not deleted
- src/tools/utils.ts: add shouldExcludeThirdPartyClients utility function for config-based exclusion - src/tools/auth0/handlers/clientGrants.ts: refactor to use shouldExcludeThirdPartyClients for filtering grants - src/tools/auth0/handlers/clients.ts: refactor to use shouldExcludeThirdPartyClients for client filtering - docs/excluding-from-management.md: update documentation to clarify client grants exclusion
kushalshit27
changed the title
AUTH0_EXCLUDE_THIRD_PARTY_CLIENTS is enabledAUTH0_EXCLUDE_THIRD_PARTY_CLIENTS is enabled
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
+ Coverage 80.39% 80.43% +0.04%
==========================================
Files 146 146
Lines 5825 5837 +12
Branches 1194 1195 +1
==========================================
+ Hits 4683 4695 +12
Misses 650 650
Partials 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
client grants handler: Added filtering logic to exclude client grants associated with third-party clients when
AUTH0_EXCLUDE_THIRD_PARTY_CLIENTSis enabled. Previously, only clients were excluded, leaving orphaned client grants in the deployment.utility function: Added
shouldExcludeThirdPartyClients()to centralise the logic for determining whether third-party clients should be excluded based on configuration.📚 References
🔬 Testing
AUTH0_EXCLUDE_THIRD_PARTY_CLIENTSis enabled📝 Checklist