-
Notifications
You must be signed in to change notification settings - Fork 174
Add support for Universal Custom Password Hash (EA) #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 80.39% 80.41% +0.01%
==========================================
Files 146 146
Lines 5825 5850 +25
Branches 1194 1200 +6
==========================================
+ Hits 4683 4704 +21
- Misses 650 652 +2
- Partials 492 494 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| let actions: Action[] = []; | ||
| try { | ||
| if (this.client.actions?.list) { | ||
| actions = await paginate<Action>(this.client.actions.list, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need all actions? Or can Action GetById also be used?
| return super.objString({ name: db.name, id: db.id }); | ||
| } | ||
|
|
||
| getFormattedOptions(database, actions: Action[] = []) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| getFormattedOptions(database, actions: Action[] = []) { | |
| getFormattedOptions(options, actions: Action[] = []) { |
| } | ||
|
|
||
| export function convertActionNameToId(name: string, actions: Asset[]): string { | ||
| const found = actions.find((a) => a.name === name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a check for undefined actions
| } | ||
|
|
||
| export function convertActionIdToName(id: string, actions: Asset[]): string { | ||
| const found = actions.find((a) => a.id === id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a check for undefined actions
Add support for action name resolution in database
custom_password_hash.action_idfield.🔧 Changes
This PR enables the Deploy CLI to accept action names instead of action IDs in the
options.custom_password_hash.action_idfield for database connections.Example Usage:
This feature supports the custom password hash functionality which is currently in Early Availability (EA). The feature is subject to change as it matures.
📚 References
🔬 Testing
📝 Checklist