build(deps): upgrade jest 30 and jest-preset-angular 17 - #1011
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request upgrades Jest tooling to version 30, updates preset imports, and adjusts two tests for compatible assertion and browser history APIs. ChangesJest 30 upgrade
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR upgrades the Jest tooling and updates compatible configuration and test assertions; with 190 tests passing, no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
package.jsonParsing error: Unexpected token : Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drops deprecated @angular/platform-browser-dynamic peer dep that caused recurring ERESOLVE conflicts on Dependabot Angular patch bumps.
Node 22 disallows directory imports in ES module context. Also regenerate lockfile with npm 10 to include @noble/hashes@2.4.0 for the jsdom tree.
66f8c76 to
f736e0d
Compare
Replace toThrowError (removed in jest 30) with toThrow, and use window.history.replaceState instead of direct location.search assignment (required by jsdom 26). All other lines restored to match main.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
jest→^30.0.0,jest-preset-angular→^17.0.0,@types/jest→^30.0.0jest-environment-jsdom@^30.0.0(no longer bundled with jest since v28)@angular/platform-browser-dynamic—jest-preset-angular@17no longer requires it, unblocking future Dependabot Angular group PRsFixes required for jest 30 / Node 22
jest.config.ts:jest-preset-angular/presets→jest-preset-angular/presets/index.js(Node 22 disallows directory imports in ES modules)auth.client.spec.ts:toThrowErrorremoved in jest 30 →toThrowauth.service.spec.ts: directwindow.location.searchassignment dropped in jsdom 26 →window.history.replaceState@noble/hashes@2.4.0peer dep introduced by jsdom 26Test plan
npm run test:ci— 190 passed, 0 failedSummary by CodeRabbit
Chores
Tests