Skip to content

Conversation

@pmathew92
Copy link
Contributor

Changes

This PR removes the public PasskeyAuthProvider and the internal PasskeyManager classes used for Passkey signup and sign-in operations in favor of using the APIs directly from the AuthenticationAPIClient class.

References

#893

Checklist

@pmathew92 pmathew92 requested a review from a team as a code owner February 10, 2026 06:28
Copilot AI review requested due to automatic review settings February 10, 2026 06:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Passkey signup/sign-in wrapper types (PasskeyAuthProvider and internal PasskeyManager) and relies on AuthenticationAPIClient’s passkey APIs directly, including cleaning up related dependencies and Proguard configuration.

Changes:

  • Removed PasskeyAuthProvider, PasskeyManager, and the associated unit tests.
  • Dropped androidx.credentials dependencies and removed the Jetpack Proguard rules file.
  • Updated the v4 migration guide to document the removal and point to AuthenticationAPIClient passkey APIs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sample/build.gradle Removes Credential Manager dependencies from the sample app.
proguard/proguard-jetpack.pro Deletes Jetpack/CredentialManager Proguard rules.
auth0/src/test/java/com/auth0/android/provider/PasskeyManagerTest.kt Removes tests for the deleted internal PasskeyManager.
auth0/src/main/java/com/auth0/android/provider/PasskeyManager.kt Deletes internal PasskeyManager implementation.
auth0/src/main/java/com/auth0/android/provider/PasskeyAuthProvider.kt Deletes deprecated public PasskeyAuthProvider wrapper.
auth0/build.gradle Removes consumer proguard include + credentials dependencies/version pin.
V4_MIGRATION_GUIDE.md Documents PasskeyAuthProvider removal and points to new API usage.
AGP_UPGRADE_PLAN.md Deletes upgrade planning document.
Comments suppressed due to low confidence (1)

proguard/proguard-jetpack.pro:1

  • This file is being removed, but EXAMPLES.md still lists proguard-jetpack.pro as a recommended Proguard rules file. Please update the docs to stop referencing this file (or keep an equivalent consumer Proguard rules file) to avoid broken guidance/links for users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -53,8 +53,6 @@ dependencies {
implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
implementation 'androidx.navigation:navigation-fragment-ktx:2.3.5'
implementation 'androidx.navigation:navigation-ui-ktx:2.3.5'
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample module still imports and uses androidx.credentials.* (e.g. sample/src/main/java/com/auth0/sample/DatabaseLoginFragment.kt uses CredentialManager, CreatePublicKeyCredentialRequest, etc.), so removing the androidx.credentials:credentials and credentials-play-services-auth dependencies here will break sample compilation. Either re-add these dependencies to the sample module, or remove/guard the passkey sample code that depends on Credential Manager.

Suggested change
implementation 'androidx.navigation:navigation-ui-ktx:2.3.5'
implementation 'androidx.navigation:navigation-ui-ktx:2.3.5'
implementation 'androidx.credentials:credentials:1.2.2'
implementation 'androidx.credentials:credentials-play-services-auth:1.2.2'

Copilot uses AI. Check for mistakes.
@pmathew92 pmathew92 merged commit 4fa184c into v4_development Feb 10, 2026
6 checks passed
@pmathew92 pmathew92 deleted the SDK-7735 branch February 10, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants