feat: parse flag values strictly in built-in providers - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in providers no longer cast flag values silently:
EnvVarProviderandRedisProviderparse raw values strictly. An invalid value (e.g."banana"as boolean,"10.0"as integer) now returns the default value withPARSE_ERROR, instead of being cast.InMemoryProviderreturnsTYPE_MISMATCHwhen the YAML type does not match the requested type. The only accepted conversions are0/1as boolean and integers as float, like typed providers such as flagd.ResolutionDetailsTrait::toBool()is replaced byparseBool(),parseInt(),parseFloat()andparseObject().RedisProvidernow logs client failures aterrorlevel. Previously, a Redis outage silently resolved every flag to its default value.The docs list the accepted values per type for each provider.