Repository navigation
Reject malformed OSC bundle element lengths - #201
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bundle element with size -4 leaves the parser at the same offset, so it loops forever. Oversized elements can also be accepted even though their contents extend past the packet.
Check that each element length is positive, aligned to four bytes and fits inside the datagram before parsing it. Invalid lengths now raise the existing ParseError, including inside nested bundles. Empty bundles remain valid.
Added regression cases for malformed, oversized and nested elements. Also corrected the declared lengths in two older valid-packet fixtures. The original negative-length loop was reproduced in a bounded subprocess; the oversized/nested cases fail on unchanged main.
All 184 tests and 10 subtests pass locally, along with project-wide Ruff formatting/lint and mypy checks. Tested on macOS/Python 3.14; hosted CI covers the other environments.
AI assistance: OpenAI Codex wrote and tested this patch.