Use atomvm_packbeam instead of built-in C packbeam #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w32/single-packbeam
branch
3 times, most recently
from
3d8ecda to
dd3936f
Compare
UncleGrumpy
approved these changes
Aug 12, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
This is a nice improvement, and should simply maintenance - focusing our efforts on a single implementation of packbeam.
This should probably include a mention that it supersedes #1429.
bettio
reviewed
Oct 5, 2025
Collaborator
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
I agree with this change but I think we should vendor here the tool we use for making .avm files. So we can build without any network access and make happy people trying to use Nix.
pguyot
force-pushed
the
w32/single-packbeam
branch
from
dd3936f to
a4d5477
Compare
Collaborator
|
Would including atomvm_packbeam here as a git submodule be enough to keep the nix people happy? |
pguyot
force-pushed
the
w32/single-packbeam
branch
from
a4d5477 to
378d6f3
Compare
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w32/single-packbeam
branch
from
378d6f3 to
75a3519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept the remove lines for release avm builds.
Added -p for runnables to prune some module (if any).
Install packbeam escript as bin/packbeam
Obsoletes #1429
Requires atomvm/atomvm_packbeam#47
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later